Skip to content

Enable direct conversion from configuration parameter to product_query#186

Merged
knoepfel merged 5 commits intoFramework-R-D:mainfrom
knoepfel:get-product-query
Dec 15, 2025
Merged

Enable direct conversion from configuration parameter to product_query#186
knoepfel merged 5 commits intoFramework-R-D:mainfrom
knoepfel:get-product-query

Conversation

@knoepfel
Copy link
Member

Closes #163.

@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
+ Coverage   81.39%   81.46%   +0.07%     
==========================================
  Files         116      117       +1     
  Lines        2085     2099      +14     
  Branches      332      332              
==========================================
+ Hits         1697     1710      +13     
+ Misses        254      252       -2     
- Partials      134      137       +3     
Flag Coverage Δ
unittests 81.46% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
phlex/configuration.cpp 100.00% <100.00%> (ø)
phlex/configuration.hpp 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f691457...131bece. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knoepfel
Copy link
Member Author

@phlexbot format

@github-actions
Copy link
Contributor

No automatic fixes were necessary.

@github-actions
Copy link
Contributor

Automatic fixes pushed (commit 666af33).
⚠️ Note: Some issues may require manual review and fixing.

Copy link
Contributor

@beojan beojan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@knoepfel knoepfel merged commit beaa933 into Framework-R-D:main Dec 15, 2025
36 checks passed
@knoepfel knoepfel deleted the get-product-query branch December 15, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable direct conversion from configuration parameter to product_query

2 participants