Skip to content

expose the kind of json values to simplify the retrieval Python-side#187

Closed
wlav wants to merge 3 commits intoFramework-R-D:mainfrom
wlav:configuration-kind
Closed

expose the kind of json values to simplify the retrieval Python-side#187
wlav wants to merge 3 commits intoFramework-R-D:mainfrom
wlav:configuration-kind

Conversation

@wlav
Copy link
Contributor

@wlav wlav commented Dec 12, 2025

Adds a basic internal kind retrieval function, which greatly simplifies lookup and type conversion in the Python configuration wrapper. (Note that this method is meant to be temporary and only for the prototype. It will change once the configuration interface itself gets fleshed out.)

Edit: I saw the test coverage fail, but it's tested by the Python code which is waiting for this to be included first.

@wlav wlav requested a review from greenc-FNAL December 12, 2025 20:19
@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
phlex/configuration.hpp 0.00% 10 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

@@             Coverage Diff             @@
##             main     #187       +/-   ##
===========================================
+ Coverage   52.94%   80.76%   +27.81%     
===========================================
  Files         114      116        +2     
  Lines        2289     2095      -194     
  Branches     1107      332      -775     
===========================================
+ Hits         1212     1692      +480     
- Misses        237      265       +28     
+ Partials      840      138      -702     
Flag Coverage Δ
unittests 80.76% <0.00%> (+27.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
phlex/configuration.hpp 41.17% <0.00%> (-28.83%) ⬇️

... and 121 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b75c557...c114d57. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knoepfel
Copy link
Member

@wlav, do you intend to add a unit test to cover the lines that are missing code coverage?

@wlav
Copy link
Contributor Author

wlav commented Dec 12, 2025

The code is being used in a Python test. :)

@wlav
Copy link
Contributor Author

wlav commented Dec 12, 2025

I can look if there's an easy way of adding a C++ test or combine this change with the larger Python PR.

@wlav
Copy link
Contributor Author

wlav commented Dec 12, 2025

I tried to temporarily add a use to one if the python tests, but it didn't like that as that test is apparently not run in the CI. I'm removing this PR and will make the change part of the larger Python PR, where it is tested.

@wlav wlav closed this Dec 12, 2025
@wlav wlav deleted the configuration-kind branch December 12, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants