expose the kind of json values to simplify the retrieval Python-side#187
expose the kind of json values to simplify the retrieval Python-side#187wlav wants to merge 3 commits intoFramework-R-D:mainfrom
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #187 +/- ##
===========================================
+ Coverage 52.94% 80.76% +27.81%
===========================================
Files 114 116 +2
Lines 2289 2095 -194
Branches 1107 332 -775
===========================================
+ Hits 1212 1692 +480
- Misses 237 265 +28
+ Partials 840 138 -702
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 121 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@wlav, do you intend to add a unit test to cover the lines that are missing code coverage? |
|
The code is being used in a Python test. :) |
|
I can look if there's an easy way of adding a C++ test or combine this change with the larger Python PR. |
|
I tried to temporarily add a use to one if the python tests, but it didn't like that as that test is apparently not run in the CI. I'm removing this PR and will make the change part of the larger Python PR, where it is tested. |
Adds a basic internal kind retrieval function, which greatly simplifies lookup and type conversion in the Python configuration wrapper. (Note that this method is meant to be temporary and only for the prototype. It will change once the configuration interface itself gets fleshed out.)
Edit: I saw the test coverage fail, but it's tested by the Python code which is waiting for this to be included first.