Enable TSAN/ASAN compiler options for only GNU#191
Merged
knoepfel merged 1 commit intoFramework-R-D:mainfrom Dec 16, 2025
Merged
Enable TSAN/ASAN compiler options for only GNU#191knoepfel merged 1 commit intoFramework-R-D:mainfrom
knoepfel merged 1 commit intoFramework-R-D:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #191 +/- ##
==========================================
- Coverage 81.61% 81.46% -0.15%
==========================================
Files 117 117
Lines 2099 2099
Branches 332 332
==========================================
- Hits 1713 1710 -3
- Misses 254 255 +1
- Partials 132 134 +2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following C++ compile options were enabled for the
GNU,Clang, andAppleClangcompilers although they are only supported forGNU:-fno-omit-frame-pointer-fno-optimize-sibling-callsThis PR replaces the
$<COMPILER_LANGUAGE:CXX>[sic, should have beenCOMPILE_LANGUAGE] generator expression with$<COMPILE_LANG_AND_ID:CXX,GNU>. It also guards the generator expression by using quotes as breaking generator expressions across multiple lines can cause problems (I did not get successful builds without the quotes).