Fix stack-use-after-scope ASAN error

phlex/model/product_specification.cpp

@@ -60,18 +60,17 @@ namespace phlex::experimental {
     return {algorithm_name::create(""), s, type_id{}};
   }
 
-  product_specifications to_product_specifications(std::string const& name,
+  product_specifications to_product_specifications(std::string const name,
                                                    std::vector<std::string> output_labels,
                                                    std::vector<type_id> output_types)
   {
     assert(output_labels.size() == output_types.size());
     product_specifications outputs;
     outputs.reserve(output_labels.size());
 
-    to_product_specification make_product_specification{name};
     // zip view isn't available until C++23 so we have to use a loop over the index
     for (std::size_t i = 0; i < output_labels.size(); ++i) {
-      outputs.push_back(make_product_specification(output_labels.at(i), output_types.at(i)));
+      outputs.emplace_back(name, output_labels[i], output_types[i]);
     }
     return outputs;
   }

phlex/model/product_specification.hpp

@@ -40,19 +40,7 @@ namespace phlex::experimental {
 
   using product_specifications = std::vector<product_specification>;
 
-  class to_product_specification {
-  public:
-    explicit to_product_specification(algorithm_name const& qualifier) : qualifier_{qualifier} {}
-    product_specification operator()(std::string const& name, type_id type) const
-    {
-      return product_specification{qualifier_, name, std::move(type)};
-    }
-
-  private:
-    algorithm_name const& qualifier_;
-  };
-
-  product_specifications to_product_specifications(std::string const& name,
+  product_specifications to_product_specifications(std::string name,
                                                    std::vector<std::string> output_labels,
                                                    std::vector<type_id> output_types);
 }