Merged
Conversation
Convert unfold_transform_fold from standalone executable to Catch2 test that verifies pipelined execution of unfold and fold stages. Test verifies: - Pipeline parallelism occurs (unfold and fold execute concurrently; the first fold operation is called before the last unfold is complete). - All expected chunks complete processing - Correctness of unfold-transform-fold workflow Updated test/demo-giantdata/CMakeLists.txt to use cet_test instead of add_executable. This approach works correctly even with a single TBB thread.
marcpaterno
requested review from
Copilot and
knoepfel
and removed request for
Copilot
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #193 +/- ##
=======================================
Coverage 81.91% 81.91%
=======================================
Files 120 120
Lines 2179 2179
Branches 349 349
=======================================
Hits 1785 1785
+ Misses 255 254 -1
- Partials 139 140 +1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
knoepfel
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modifies the
unfold_transform_folddemo program into an actual test that verifies that the pipeline parallelism required by DUNE is working.