Skip to content

Remove restriction on number of threads for framework_graph#194

Merged
marcpaterno merged 1 commit intoFramework-R-D:mainfrom
knoepfel:remove-threading-restriction
Dec 16, 2025
Merged

Remove restriction on number of threads for framework_graph#194
marcpaterno merged 1 commit intoFramework-R-D:mainfrom
knoepfel:remove-threading-restriction

Conversation

@knoepfel
Copy link
Member

Previous implementations of async_driver required at least 2 threads to be configured for the oneTBB task scheduler. After switching to a std::[j]thread implementation of the async_driver, the restriction on the number of threads used by the oneTBB task scheduler can be removed.

@knoepfel knoepfel force-pushed the remove-threading-restriction branch from 95e9b26 to 7d4f8b0 Compare December 16, 2025 19:47
@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
+ Coverage   81.91%   82.03%   +0.12%     
==========================================
  Files         120      120              
  Lines        2179     2177       -2     
  Branches      349      348       -1     
==========================================
+ Hits         1785     1786       +1     
+ Misses        254      253       -1     
+ Partials      140      138       -2     
Flag Coverage Δ
unittests 82.03% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
phlex/core/framework_graph.cpp 88.37% <ø> (+2.00%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de46956...7d4f8b0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcpaterno marcpaterno self-requested a review December 16, 2025 23:47
@marcpaterno marcpaterno merged commit 42f6774 into Framework-R-D:main Dec 16, 2025
36 checks passed
@knoepfel knoepfel deleted the remove-threading-restriction branch February 25, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants