Skip to content

fix(ci): Ensure CodeQL comment workflow only runs on success #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greenc-FNAL merged 2 commits into from
Jan 20, 2026
Merged

fix(ci): Ensure CodeQL comment workflow only runs on success #258

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
839bde7
fix(ci): Ensure CodeQL comment workflow only runs on success
google-labs-jules[bot] Jan 20, 2026
52f42bd
fix(ci): Ensure CodeQL comment workflow runs on success or failure
google-labs-jules[bot] Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/codeql-comment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,13 @@ permissions:
jobs:
post-comment:
runs-on: ubuntu-latest
if: github.event.workflow_run.event == 'pull_request' && github.event.workflow_run.conclusion != 'cancelled'
# This job runs on both 'success' and 'failure' of the 'CodeQL Analysis' workflow.
# The upstream workflow intentionally fails if it finds new alerts, but it uploads
# the comment artifact before doing so. This condition ensures the comment is posted
# in both cases (new alerts found, or existing alerts resolved).
# The workflow is resilient to other failures because the 'Post Comment' step
# only runs if the artifact was successfully downloaded.
if: github.event.workflow_run.event == 'pull_request' && (github.event.workflow_run.conclusion == 'success' || github.event.workflow_run.conclusion == 'failure')
steps:
- name: Download PR comment data
uses: actions/download-artifact@fa0a91b85d4f404e8442c7c958156baef1102941 # v4.1.8
Expand Down
Loading