Skip to content

Upgrade Phlex to build with C++23#284

Merged
knoepfel merged 4 commits intoFramework-R-D:mainfrom
knoepfel:cpp23-for-containers
Feb 5, 2026
Merged

Upgrade Phlex to build with C++23#284
knoepfel merged 4 commits intoFramework-R-D:mainfrom
knoepfel:cpp23-for-containers

Conversation

@knoepfel
Copy link
Copy Markdown
Member

@knoepfel knoepfel commented Feb 3, 2026

This PR contains the following:

  • Changes the base container image from gcc:15.2.0 (Debian-based) to ubuntu:24.04 as the latter matches the OS supported by GitHub Actions runners
  • Builds GCC 15.2.0 using Spack and loads it as necessary when building phlex
  • Changes the Spack environment specification to use cxxstd=23 where appropriate
  • Adjust the CMake preset to use C++23

@knoepfel knoepfel force-pushed the cpp23-for-containers branch from 363e5fd to 39363ec Compare February 3, 2026 20:40
@greenc-FNAL
Copy link
Copy Markdown
Contributor

Note: your container uses LLVM/Clang 21.1.8 rather than the previous 21.1.4. Would need to look closer to see if that causes an issue somehow, though.

@knoepfel knoepfel force-pushed the cpp23-for-containers branch 5 times, most recently from bb3142d to 4d910af Compare February 5, 2026 15:24
@knoepfel knoepfel closed this Feb 5, 2026
@knoepfel knoepfel reopened this Feb 5, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

❌ Your project status has failed because the head coverage (74.04%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
- Coverage   74.28%   74.04%   -0.24%     
==========================================
  Files         124      124              
  Lines        2955     2955              
  Branches      513      513              
==========================================
- Hits         2195     2188       -7     
- Misses        540      545       +5     
- Partials      220      222       +2     
Flag Coverage Δ
unittests 74.04% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 040a4e6...955e316. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knoepfel knoepfel force-pushed the cpp23-for-containers branch 4 times, most recently from 2610c9d to 455ef32 Compare February 5, 2026 19:11
@knoepfel knoepfel force-pushed the cpp23-for-containers branch from 455ef32 to e2fc27e Compare February 5, 2026 19:31
@knoepfel knoepfel requested a review from greenc-FNAL February 5, 2026 19:35
@knoepfel knoepfel changed the title Upgrade containers to C++23 Upgrade Phlex to build with C++23 Feb 5, 2026
@knoepfel knoepfel requested review from beojan February 5, 2026 20:09
beojan
beojan previously approved these changes Feb 5, 2026
Copy link
Copy Markdown
Contributor

@beojan beojan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issues

@knoepfel knoepfel dismissed greenc-FNAL’s stale review February 5, 2026 20:17

I believe I addressed the requested changes.

@knoepfel knoepfel force-pushed the cpp23-for-containers branch from e2fc27e to 955e316 Compare February 5, 2026 21:27
@knoepfel knoepfel requested a review from greenc-FNAL February 5, 2026 21:29
@knoepfel knoepfel dismissed greenc-FNAL’s stale review February 5, 2026 21:29

Added code comments as requested

@knoepfel knoepfel merged commit bfd25ca into Framework-R-D:main Feb 5, 2026
43 of 44 checks passed
@knoepfel knoepfel deleted the cpp23-for-containers branch February 5, 2026 21:52
@knoepfel knoepfel linked an issue Feb 6, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate from C++20 to C++23

3 participants