Skip to content

Remove not-strictly-necessary error checking to improve coverage

1d1e4ad
Select commit
Loading
Failed to load commit list.
Merged

Add phlex::identifier #288

Remove not-strictly-necessary error checking to improve coverage
1d1e4ad
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 10, 2026 in 0s

75.32% (target 80.00%)

View this Pull Request on Codecov

75.32% (target 80.00%)

Details

Codecov Report

❌ Patch coverage is 84.61538% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
phlex/model/identifier.cpp 82.35% 2 Missing and 1 partial ⚠️
phlex/model/identifier.hpp 85.71% 1 Missing ⚠️

❌ Your project check has failed because the head coverage (75.32%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
+ Coverage   74.28%   75.32%   +1.04%     
==========================================
  Files         124      126       +2     
  Lines        2955     2954       -1     
  Branches      513      519       +6     
==========================================
+ Hits         2195     2225      +30     
+ Misses        540      505      -35     
- Partials      220      224       +4     
Files with missing lines Coverage Δ
phlex/configuration.cpp 87.50% <100.00%> (+64.09%) ⬆️
phlex/configuration.hpp 95.23% <ø> (ø)
phlex/model/identifier.hpp 85.71% <85.71%> (ø)
phlex/model/identifier.cpp 82.35% <82.35%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20c5955...1d1e4ad. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.