Remove vestigial inheritance from std::enable_shared_from_this#293
Merged
knoepfel merged 1 commit intoFramework-R-D:mainfrom Feb 9, 2026
Merged
Remove vestigial inheritance from std::enable_shared_from_this#293knoepfel merged 1 commit intoFramework-R-D:mainfrom
std::enable_shared_from_this#293knoepfel merged 1 commit intoFramework-R-D:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (74.46%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. @@ Coverage Diff @@
## main #293 +/- ##
==========================================
+ Coverage 74.28% 74.46% +0.18%
==========================================
Files 124 124
Lines 2955 2961 +6
Branches 513 516 +3
==========================================
+ Hits 2195 2205 +10
+ Misses 540 534 -6
- Partials 220 222 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
knoepfel
force-pushed
the
remove-enable-shared
branch
from
34b5254 to
9d9deff
Compare
Contributor
|
Review the full CodeQL report for details. |
marcpaterno
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
product_storeclass' inheritance fromstd::enable_shared_from_thisis no longer need asshared_from_this()is not used anymore.