Conversation
The coverage job was not running when triggered via workflow_dispatch because detect-changes was being skipped, and the coverage job's condition didn't handle the skipped state properly. Changed the coverage job condition to match the pattern used in other check workflows (e.g., python-check.yaml), which runs when detect-changes is either skipped OR succeeded with changes. Also updated detect-changes and coverage-skipped jobs to follow the same pattern for consistency. Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix workflow logic for unconditional coverage execution
Fix coverage workflow to run unconditionally on workflow_dispatch
Feb 6, 2026
Updated the build job condition in cmake-build.yaml to use the same pattern as other check workflows: checking if detect-changes was skipped OR if it succeeded with changes. This is functionally equivalent to the previous explicit event checks but more maintainable and consistent: - workflow_dispatch → detect-changes skipped → build runs - issue_comment → detect-changes skipped → build runs - workflow_call with skip-relevance-check → detect-changes skipped → build runs - act environment → detect-changes skipped → build runs Benefits: 1. Consistency with all other check workflows 2. Less maintenance when adding new trigger events 3. Simpler, more declarative logic Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the Code Coverage GitHub Actions workflow so the coverage job runs correctly when the workflow is manually triggered via workflow_dispatch, even though detect-changes is skipped in that event mode.
Changes:
- Update
coveragejob gating to run whendetect-changesisskipped, or when it ran and detected relevant changes. - Add a
needs.pre-check.result == 'success'guard todetect-changesandcoverage-skippedfor consistency with other workflows.
Copilot
AI
changed the title
Fix coverage workflow to run unconditionally on workflow_dispatch
Fix workflow_dispatch execution in coverage and cmake-build workflows
Feb 6, 2026
greenc-FNAL
approved these changes
Feb 6, 2026
The pre-check job was missing 'push' in its event condition, causing the entire workflow to be skipped when code was pushed to main or develop branches. Added github.event_name == 'push' to the pre-check job condition so the workflow runs correctly for push events. This ensures CI builds run automatically on every push to main/develop. Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
Copilot
AI
changed the title
Fix workflow_dispatch execution in coverage and cmake-build workflows
Fix workflow execution: coverage/build on workflow_dispatch, build on push to main
Feb 6, 2026
knoepfel
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three critical workflow issues prevented CI from running correctly:
Root Causes
Incorrect detect-changes handling: Jobs checked explicit event names (
github.event_name == 'workflow_dispatch') instead of testing whetherdetect-changeswas skipped. Whendetect-changesskips (workflow_dispatch, act, etc.), its result is'skipped'not'success', so conditions failed.Missing push event: The
pre-checkjob enumerated specific events but omittedpushdespite the workflow being triggered by push events.Changes
coverage.yaml
cmake-build.yaml
This pattern matches all other check workflows (python-check, clang-tidy-check, etc.) and is more maintainable—no need to update conditions when adding new trigger events.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.