Skip to content

Fix CodeQL alert: Remove secret token export in handle-fix-commit action #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knoepfel merged 5 commits into from
Feb 10, 2026
Merged

Fix CodeQL alert: Remove secret token export in handle-fix-commit action #302

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
218c788
Initial plan
Copilot Feb 9, 2026
d20b862
Fix security issue: avoid exporting secret token as environment variable
Copilot Feb 9, 2026
15c43bc
Add restrictive file permissions for credentials file
Copilot Feb 9, 2026
6455424
Address copilot review
greenc-FNAL Feb 9, 2026
487b8fa
Improve credential safety
greenc-FNAL Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/actions/handle-fix-commit/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,8 @@ runs:
git config --local user.name "github-actions[bot]"
git config --local user.email "41898282+github-actions[bot]@users.noreply.github.com"

export GITHUB_TOKEN=${{ inputs.token }}
trap 'rm -f ~/.git-credentials' EXIT
echo "https://x-access-token:${GITHUB_TOKEN}@github.com" > ~/.git-credentials
(umask 077 && echo "https://x-access-token:${{ inputs.token }}@github.com" > ~/.git-credentials)
git config --local credential.helper 'store --file ~/.git-credentials'

git add -u
Expand Down
Loading