Rename product_store::id() to product_store::index()#303
Merged
knoepfel merged 1 commit intoFramework-R-D:mainfrom Feb 10, 2026
Merged
Rename product_store::id() to product_store::index()#303knoepfel merged 1 commit intoFramework-R-D:mainfrom
product_store::id() to product_store::index()#303knoepfel merged 1 commit intoFramework-R-D:mainfrom
Conversation
Contributor
|
Review the full CodeQL report for details. |
Codecov Report❌ Patch coverage is ❌ Your project status has failed because the head coverage (75.55%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. @@ Coverage Diff @@
## main #303 +/- ##
==========================================
- Coverage 75.59% 75.55% -0.04%
==========================================
Files 126 126
Lines 2954 2954
Branches 519 519
==========================================
- Hits 2233 2232 -1
Misses 500 500
- Partials 221 222 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This is to better express that a given product store corresponds to a given data-cell index.
knoepfel
force-pushed
the
rename-id-to-index
branch
from
9cf4e1a to
3a58a78
Compare
marcpaterno
approved these changes
Feb 10, 2026
Member
marcpaterno
left a comment
marcpaterno
left a comment
There was a problem hiding this comment.
The matches the terminology in the CDR.
greenc-FNAL
pushed a commit
that referenced
this pull request
Feb 10, 2026
This is to better express that a given product store corresponds to a given data-cell index.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to better express that a given product store corresponds to a given data-cell index.
N.B. There are no functionality changes with this PR; just a renaming of a member function.