Skip to content

Add codespace setup for companion repositories#310

Merged
greenc-FNAL merged 10 commits intomainfrom
copilot/setup-personal-codespace
Feb 12, 2026
Merged

Add codespace setup for companion repositories#310
greenc-FNAL merged 10 commits intomainfrom
copilot/setup-personal-codespace

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 10, 2026

  • Create setup-repos.sh script to clone companion repos on codespace creation
  • Add onCreateCommand to devcontainer.json to run setup script
  • Create multi-root codespace.code-workspace with all five repos
  • Update copilot-instructions.md with repository ecosystem and codespace layout docs
  • Address review: fix misleading rm message when directory doesn't exist
  • Address review: guard rm -rf with existence check
  • Address review: sync C++ standard to c++23 across devcontainer.json, codespace.code-workspace, and phlex.code-workspace
  • Address review: clarify phlex-design description to avoid ambiguity with phlex-coding-guidelines
  • Run code review (no issues)
  • Run CodeQL security scan (no applicable code changes)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Set up personal codespace for development and AI sessions Add codespace setup for companion repositories Feb 10, 2026
Copilot AI requested a review from greenc-FNAL February 10, 2026 17:07
@greenc-FNAL greenc-FNAL marked this pull request as ready for review February 10, 2026 17:41
Copilot AI review requested due to automatic review settings February 10, 2026 17:41
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Codespace/devcontainer automation to bring Phlex companion repositories (design docs, examples, coding guidelines, Spack recipes) into the same /workspaces environment as the main phlex repo, and documents the resulting layout for developers and Copilot agents.

Changes:

  • Adds an onCreateCommand that clones companion repos into /workspaces.
  • Introduces a multi-root VS Code workspace spanning phlex plus companion repos.
  • Documents the repository ecosystem and Codespace directory layout in Copilot instructions.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
.github/copilot-instructions.md Documents companion repos and the /workspaces/* layout for Codespaces/devcontainers.
.devcontainer/setup-repos.sh New script to shallow-clone companion repositories into /workspaces.
.devcontainer/devcontainer.json Runs the setup script via onCreateCommand during container creation.
.devcontainer/codespace.code-workspace Adds a multi-root workspace that opens all repos together and sets shared tooling settings.
Comments suppressed due to low confidence (2)

.devcontainer/setup-repos.sh:32

  • This file ends with a trailing blank line. Repo text-formatting rules require the final line be non-empty and the file to end with exactly one newline (no extra blank lines at EOF). Remove the extra blank line at the end.
clone_if_absent phlex-spack-recipes

.devcontainer/codespace.code-workspace:120

  • This workspace file ends with a trailing blank line. Repo text-formatting rules require the final line be non-empty and the file to end with exactly one newline (no extra blank lines at EOF). Remove the extra blank line at the end.
}

@greenc-FNAL
Copy link
Copy Markdown
Contributor

Review the full CodeQL report for details.

@greenc-FNAL greenc-FNAL force-pushed the copilot/setup-personal-codespace branch from 556589e to aa6ace8 Compare February 12, 2026 21:21
greenc-FNAL added a commit that referenced this pull request Feb 12, 2026
Per #310 (comment)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@greenc-FNAL greenc-FNAL requested a review from Copilot February 12, 2026 21:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

Copilot AI and others added 6 commits February 12, 2026 15:35
…delines, spack-recipes)

Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
… paths

Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
Per #310 (comment)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…++23 standard, clarify repo descriptions

Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Feb 12, 2026

Review the full CodeQL report for details.

I don't have access to the code scanning alerts API for this repository. The changes in this PR are configuration files (JSON, Markdown, shell script) which CodeQL doesn't analyze — the local CodeQL check confirms no applicable code changes were detected. If there are alerts in the report, they're likely pre-existing or from other branches.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@greenc-FNAL greenc-FNAL requested a review from knoepfel February 12, 2026 22:26
@greenc-FNAL greenc-FNAL merged commit c66e143 into main Feb 12, 2026
45 checks passed
@greenc-FNAL greenc-FNAL deleted the copilot/setup-personal-codespace branch February 13, 2026 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants