Skip to content

Remove unneeded checking in edge_maker #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knoepfel merged 1 commit into from
Feb 11, 2026
Merged

Remove unneeded checking in edge_maker #312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions phlex/core/edge_maker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@ namespace phlex::experimental {
provider.full_name(),
node_name,
port.product_label.to_string());
if (port.port == nullptr) {
throw std::runtime_error("Unexpected null port while connecting provider " +
provider.full_name() + " to node " + node_name);
}
make_edge(provider.sender(), *(port.port));
found_match = true;
break;
Expand Down
7 changes: 0 additions & 7 deletions phlex/core/edge_maker.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,6 @@ namespace phlex::experimental {
continue;
}

if (producer->port == nullptr or receiver_port == nullptr) {
throw std::runtime_error("Unexpected null port while connecting " +
producer->node.full() + " to " + node_name);
}
make_edge(*producer->port, *receiver_port);
}
}
Expand All @@ -97,9 +93,6 @@ namespace phlex::experimental {
for (auto const& [output_name, output_node] : outputs) {
make_edge(source, output_node->port());
for (auto const& named_port : producers_.values()) {
if (named_port.to_output == nullptr) {
throw std::runtime_error("Unexpected null output port for " + named_port.node.full());
}
make_edge(*named_port.to_output, output_node->port());
}
}
Expand Down
Loading