Conversation
There was a problem hiding this comment.
Pull request overview
This PR modernizes the build system by migrating the phlex executable from add_executable() to cet_make_exec(), which is the cetmodules standard for creating executables. The migration creates a namespaced alias phlex::phlex that improves clarity and consistency throughout the test suite.
Changes:
- Converted
phlexexecutable definition to usecet_make_exec()inphlex/app/CMakeLists.txt - Updated all test references to use the namespaced
phlex::phlextarget instead of barephlex
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| phlex/app/CMakeLists.txt | Converted from add_executable() to cet_make_exec() for phlex executable, removing explicit install command (handled automatically by cet_make_exec) |
| test/python/CMakeLists.txt | Updated all add_test() COMMAND references from phlex to phlex::phlex (15 test updates) |
| test/plugins/CMakeLists.txt | Updated cet_test() TEST_EXEC from phlex to phlex::phlex |
| test/mock-workflow/CMakeLists.txt | Updated cet_test() TEST_EXEC from phlex to phlex::phlex |
| test/max-parallelism/CMakeLists.txt | Updated cet_test() TEST_EXEC from phlex to phlex::phlex (4 test updates) |
| test/form/CMakeLists.txt | Updated cet_test() TEST_EXEC from phlex to phlex::phlex |
| test/benchmarks/CMakeLists.txt | Updated cet_test() TEST_EXEC from phlex to phlex::phlex |
- Use scoped `phlex::phlex`in tests for clarity
3534cb9 to
815b952
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #336 +/- ##
=======================================
Coverage 80.39% 80.39%
=======================================
Files 127 127
Lines 3102 3102
Branches 547 547
=======================================
Hits 2494 2494
Misses 381 381
Partials 227 227
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Factored out of #329.
phlex::phlexin tests for clarity