Skip to content

Use cet_make_exec() for phlex#336

Merged
knoepfel merged 1 commit intomainfrom
maintenance/scoped-phlex-target
Feb 18, 2026
Merged

Use cet_make_exec() for phlex#336
knoepfel merged 1 commit intomainfrom
maintenance/scoped-phlex-target

Conversation

@greenc-FNAL
Copy link
Contributor

@greenc-FNAL greenc-FNAL commented Feb 18, 2026

Factored out of #329.

  • Use scoped phlex::phlexin tests for clarity

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the build system by migrating the phlex executable from add_executable() to cet_make_exec(), which is the cetmodules standard for creating executables. The migration creates a namespaced alias phlex::phlex that improves clarity and consistency throughout the test suite.

Changes:

  • Converted phlex executable definition to use cet_make_exec() in phlex/app/CMakeLists.txt
  • Updated all test references to use the namespaced phlex::phlex target instead of bare phlex

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
phlex/app/CMakeLists.txt Converted from add_executable() to cet_make_exec() for phlex executable, removing explicit install command (handled automatically by cet_make_exec)
test/python/CMakeLists.txt Updated all add_test() COMMAND references from phlex to phlex::phlex (15 test updates)
test/plugins/CMakeLists.txt Updated cet_test() TEST_EXEC from phlex to phlex::phlex
test/mock-workflow/CMakeLists.txt Updated cet_test() TEST_EXEC from phlex to phlex::phlex
test/max-parallelism/CMakeLists.txt Updated cet_test() TEST_EXEC from phlex to phlex::phlex (4 test updates)
test/form/CMakeLists.txt Updated cet_test() TEST_EXEC from phlex to phlex::phlex
test/benchmarks/CMakeLists.txt Updated cet_test() TEST_EXEC from phlex to phlex::phlex

- Use scoped `phlex::phlex`in tests for clarity
@greenc-FNAL greenc-FNAL force-pushed the maintenance/scoped-phlex-target branch from 3534cb9 to 815b952 Compare February 18, 2026 21:17
@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##             main     #336   +/-   ##
=======================================
  Coverage   80.39%   80.39%           
=======================================
  Files         127      127           
  Lines        3102     3102           
  Branches      547      547           
=======================================
  Hits         2494     2494           
  Misses        381      381           
  Partials      227      227           
Flag Coverage Δ
unittests 80.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f508fb6...815b952. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knoepfel knoepfel merged commit 711010d into main Feb 18, 2026
51 checks passed
@knoepfel knoepfel deleted the maintenance/scoped-phlex-target branch February 18, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants