Skip to content

Actually using the new product_query (Part 1) #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knoepfel merged 38 commits into from
Mar 4, 2026

Merge branch 'main' into new-product-query

9c84445
Select commit
Loading
Failed to load commit list.
Merged

Actually using the new product_query (Part 1) #344

Merge branch 'main' into new-product-query
9c84445
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 4, 2026 in 0s

86.67% (target 80.00%)

View this Pull Request on Codecov

86.67% (target 80.00%)

Details

Codecov Report

❌ Patch coverage is 80.64516% with 30 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
phlex/core/input_arguments.hpp 42.85% 10 Missing and 2 partials ⚠️
phlex/model/algorithm_name.cpp 76.47% 6 Missing and 2 partials ⚠️
phlex/model/product_specification.cpp 81.25% 2 Missing and 1 partial ⚠️
phlex/core/message.cpp 0.00% 2 Missing ⚠️
phlex/core/edge_creation_policy.cpp 50.00% 0 Missing and 1 partial ⚠️
phlex/core/edge_creation_policy.hpp 0.00% 0 Missing and 1 partial ⚠️
phlex/core/product_query.cpp 85.71% 0 Missing and 1 partial ⚠️
phlex/core/product_query.hpp 0.00% 1 Missing ⚠️
phlex/model/product_store.cpp 80.00% 1 Missing ⚠️ 
@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
+ Coverage   86.51%   86.67%   +0.16%     
==========================================
  Files         119      119              
  Lines        2403     2462      +59     
  Branches      387      391       +4     
==========================================
+ Hits         2079     2134      +55     
- Misses        206      210       +4     
  Partials      118      118
Files with missing lines Coverage Δ
form/form_module.cpp 89.13% <100.00%> (ø)
phlex/core/consumer.cpp 100.00% <100.00%> (ø)
phlex/core/declared_fold.hpp 95.31% <100.00%> (ø)
phlex/core/declared_provider.hpp 100.00% <100.00%> (ø)
phlex/core/declared_unfold.cpp 83.33% <ø> (ø)
phlex/core/declared_unfold.hpp 96.42% <ø> (ø)
phlex/core/detail/filter_impl.cpp 95.23% <100.00%> (ø)
phlex/core/detail/make_algorithm_name.cpp 100.00% <100.00%> (ø)
phlex/core/edge_maker.hpp 100.00% <ø> (ø)
phlex/core/index_router.cpp 91.81% <100.00%> (ø)
... and 23 more

... and 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 103c08c...9c84445. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov