refactor: replace technology if-else chain with C++20 lookup table#349
Merged
refactor: replace technology if-else chain with C++20 lookup table#349
Conversation
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #349 +/- ##
==========================================
+ Coverage 82.26% 82.43% +0.16%
==========================================
Files 127 127
Lines 3102 3102
Branches 547 546 -1
==========================================
+ Hits 2552 2557 +5
+ Misses 333 328 -5
Partials 217 217
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
gemmeren
previously approved these changes
Feb 22, 2026
Contributor
gemmeren
left a comment
There was a problem hiding this comment.
Thanks @wwuoneway , this looks good to me.
knoepfel
reviewed
Feb 24, 2026
knoepfel
reviewed
Feb 24, 2026
knoepfel
reviewed
Feb 24, 2026
Member
knoepfel
left a comment
There was a problem hiding this comment.
@wwuoneway, thanks for the PR. Just added a couple comments.
knoepfel
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is a refactor and clean-up test to modernize the module registration logic.
Why