Skip to content

Add verification step to FORM write/read test#351

Merged
knoepfel merged 5 commits intomainfrom
barnali/form-verification
Feb 25, 2026
Merged

Add verification step to FORM write/read test#351
knoepfel merged 5 commits intomainfrom
barnali/form-verification

Conversation

@barnaliy
Copy link
Contributor

No description provided.

@gemmeren
Copy link
Contributor

@phlexbot format

@github-actions
Copy link
Contributor

Automatic clang-format fixes pushed (commit 3ed91c3).
⚠️ Note: Some issues may require manual review and fixing.

@github-actions
Copy link
Contributor

No automatic markdownlint fixes were necessary.

@github-actions
Copy link
Contributor

No automatic jsonnetfmt fixes were necessary.

@github-actions
Copy link
Contributor

Automatic cmake-format fixes pushed (commit 0bb84a0).
⚠️ Note: Some issues may require manual review and fixing.

@barnaliy barnaliy requested a review from pcanal February 23, 2026 18:59
@barnaliy barnaliy marked this pull request as ready for review February 23, 2026 19:01
@barnaliy
Copy link
Contributor Author

@gemmeren : Sorry about that — those comments were just to keep track of changes during development and I forgot to remove them before opening the PR. Removed now. Thanks for pointing out!

@barnaliy barnaliy requested a review from knoepfel February 23, 2026 19:34
@barnaliy
Copy link
Contributor Author

If clang-format is the only thing failing, I will apply @phlexbot format at the end once all review comments are addressed, to avoid rebase conflicts during the review process.

@gemmeren
Copy link
Contributor

@phlexbot format

@github-actions
Copy link
Contributor

No automatic jsonnetfmt fixes were necessary.

@github-actions
Copy link
Contributor

No automatic markdownlint fixes were necessary.

@github-actions
Copy link
Contributor

No automatic cmake-format fixes were necessary.

@github-actions
Copy link
Contributor

Automatic clang-format fixes pushed (commit b59e6e5).
⚠️ Note: Some issues may require manual review and fixing.

Copy link
Contributor

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFTM

Copy link
Contributor

@wwuoneway wwuoneway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #351      +/-   ##
==========================================
+ Coverage   82.26%   82.33%   +0.06%     
==========================================
  Files         127      127              
  Lines        3102     3102              
  Branches      547      547              
==========================================
+ Hits         2552     2554       +2     
  Misses        333      333              
+ Partials      217      215       -2     
Flag Coverage Δ
unittests 82.33% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a26780a...b59e6e5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knoepfel knoepfel merged commit b85121d into main Feb 25, 2026
55 checks passed
@knoepfel knoepfel deleted the barnali/form-verification branch February 25, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants