Reduce number of graph ports and edges#361
Merged
knoepfel merged 2 commits intoFramework-R-D:mainfrom Feb 26, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #361 +/- ##
==========================================
- Coverage 83.38% 83.37% -0.02%
==========================================
Files 129 129
Lines 3220 3212 -8
Branches 545 545
==========================================
- Hits 2685 2678 -7
Misses 324 324
+ Partials 211 210 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
c08f10f to
d800bed
Compare
Contributor
|
I will take a look. I am busy finishing up something unrelated to DUNE, but probably will get to this later this afternoon. |
wddgit
approved these changes
Feb 26, 2026
Contributor
wddgit
left a comment
There was a problem hiding this comment.
Looked good to me. I don't see any problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #118 now merged, the number of ports for each node can be reduced:
sender()andto_output()port for each node; they have both been collapsed into one calledoutput_port()