Skip to content

Reduce number of graph ports and edges#361

Merged
knoepfel merged 2 commits intoFramework-R-D:mainfrom
knoepfel:graph-simplifications
Feb 26, 2026
Merged

Reduce number of graph ports and edges#361
knoepfel merged 2 commits intoFramework-R-D:mainfrom
knoepfel:graph-simplifications

Conversation

@knoepfel
Copy link
Member

With #118 now merged, the number of ports for each node can be reduced:

  • There no longer is a separate sender() and to_output() port for each node; they have both been collapsed into one called output_port()
    • This means that only one message is sent from a node instead of two.
  • There no longer needs to be a separate flush message emitted for each iteration while unfolding a data product

@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
- Coverage   83.38%   83.37%   -0.02%     
==========================================
  Files         129      129              
  Lines        3220     3212       -8     
  Branches      545      545              
==========================================
- Hits         2685     2678       -7     
  Misses        324      324              
+ Partials      211      210       -1     
Flag Coverage Δ
unittests 83.37% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
phlex/core/declared_fold.hpp 95.16% <100.00%> (ø)
phlex/core/declared_provider.hpp 100.00% <100.00%> (ø)
phlex/core/declared_transform.hpp 88.23% <100.00%> (-1.24%) ⬇️
phlex/core/declared_unfold.hpp 96.42% <100.00%> (ø)
phlex/core/edge_creation_policy.hpp 80.00% <100.00%> (-1.82%) ⬇️
phlex/core/edge_maker.cpp 77.27% <100.00%> (ø)
phlex/core/edge_maker.hpp 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9403b1d...d800bed. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knoepfel knoepfel force-pushed the graph-simplifications branch from c08f10f to d800bed Compare February 25, 2026 15:46
@knoepfel knoepfel requested a review from wddgit February 25, 2026 16:27
@wddgit
Copy link
Contributor

wddgit commented Feb 25, 2026

I will take a look. I am busy finishing up something unrelated to DUNE, but probably will get to this later this afternoon.

Copy link
Contributor

@wddgit wddgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked good to me. I don't see any problems.

@knoepfel knoepfel merged commit e6464db into Framework-R-D:main Feb 26, 2026
52 checks passed
@knoepfel knoepfel deleted the graph-simplifications branch February 26, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants