Skip to content

Exercise oneTBB preview feature of supporting limited resources - #366

Merged
knoepfel merged 2 commits into
Framework-R-D:mainfrom
knoepfel:tbb-preview-resource-limiting
Mar 3, 2026
Merged

knoepfel merged 2 commits into
Framework-R-D:mainfrom
knoepfel:tbb-preview-resource-limiting

Conversation

@knoepfel

@knoepfel knoepfel commented Feb 25, 2026 •

Copy link
Copy Markdown
Member

This PR exercises the proposed features described at uxlfoundation/oneTBB#1964.

Because our CI container does not yet include a build with the proposed software, I attach printouts showing successful executions of each test case:

This PR also removes the phlex/graph subdirectory and its own support for limited resources, in favor of the oneTBB implementation.

@knoepfel
knoepfel force-pushed the tbb-preview-resource-limiting branch from 945c428 to f43fe05 Compare February 25, 2026 21:02
@codecov

codecov Bot commented Feb 25, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
- Coverage   85.36%   85.20%   -0.17%     
==========================================
  Files         122      119       -3     
  Lines        2433     2399      -34     
  Branches      389      387       -2     
==========================================
- Hits         2077     2044      -33     
+ Misses        233      232       -1     
  Partials      123      123              
Flag Coverage Δ
unittests 85.20% <ø> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1dd203...1275090. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knoepfel
knoepfel force-pushed the tbb-preview-resource-limiting branch from f43fe05 to f84b2d7 Compare February 27, 2026 16:20

@marcpaterno marcpaterno left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this testing is sufficient. I am not at all sure how to test that the implementation achieves the goals of "fairness", etc. Perhaps we should discuss the feasibility of unit- or integration-tests of such things with the oneTBB team members?

@knoepfel

knoepfel commented Mar 3, 2026

Copy link
Copy Markdown
Member Author

I think this testing is sufficient. I am not at all sure how to test that the implementation achieves the goals of "fairness", etc. Perhaps we should discuss the feasibility of unit- or integration-tests of such things with the oneTBB team members?

Thanks, @marcpaterno. See #378.

@knoepfel
knoepfel merged commit 30457cd into Framework-R-D:main Mar 3, 2026
56 checks passed
@knoepfel
knoepfel deleted the tbb-preview-resource-limiting branch March 3, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants