Skip to content

Simplify specification of product-query fields#373

Open
knoepfel wants to merge 1 commit intoFramework-R-D:mainfrom
knoepfel:simplify-product-query-spec
Open

Simplify specification of product-query fields#373
knoepfel wants to merge 1 commit intoFramework-R-D:mainfrom
knoepfel:simplify-product-query-spec

Conversation

@knoepfel
Copy link
Member

This enables a product_query specification like:

-    .input_family(product_query{.creator = "input"_id, .layer = "event"_id, .suffix = "id"_id})
+    .input_family(product_query{.creator = "input", .layer = "event", .suffix = "id"})

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
- Coverage   83.77%   83.69%   -0.09%     
==========================================
  Files         126      126              
  Lines        3291     3287       -4     
  Branches      583      582       -1     
==========================================
- Hits         2757     2751       -6     
  Misses        325      325              
- Partials      209      211       +2     
Flag Coverage Δ
unittests 83.69% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
phlex/core/product_query.hpp 81.81% <100.00%> (-4.85%) ⬇️
phlex/model/identifier.hpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9c382c...75984d5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knoepfel knoepfel requested a review from beojan March 2, 2026 15:15
@beojan
Copy link
Contributor

beojan commented Mar 2, 2026

The original design idea was that it should be very clear where you're creating an identifier vs a string, but that's somewhat fallen by the wayside after adding the std::string move constructor.

Can we back out the change to a single required class (while keeping the change to constructible_from) so we keep the clear error messages?

@knoepfel
Copy link
Member Author

knoepfel commented Mar 2, 2026

The original design idea was that it should be very clear where you're creating an identifier vs a string, but that's somewhat fallen by the wayside after adding the std::string move constructor.

Can we back out the change to a single required class (while keeping the change to constructible_from) so we keep the clear error messages?

Yes, I'll adjust it so we can maintain the clear error message

@knoepfel knoepfel force-pushed the simplify-product-query-spec branch from 0287787 to 75984d5 Compare March 4, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants