Skip to content

Remove unwanted (and unhelpful) extra check #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greenc-FNAL merged 1 commit into from
Feb 27, 2026
Merged

Remove unwanted (and unhelpful) extra check #374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/actions/handle-fix-commit/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,14 @@ runs:
fi

- name: No changes to apply
if: steps.check_changes.outputs.changes == 'false' && github.event.pull_request.number
if: steps.check_changes.outputs.changes == 'false'
uses: thollander/actions-comment-pull-request@24bffb9b452ba05a4f3f77933840a6a841d1b32b # v3.0.1
with:
message: 'No automatic ${{ inputs.tool }} fixes were necessary.'

- name: Get PR maintainer_can_modify property
id: pr-properties
if: steps.check_changes.outputs.changes == 'true' && github.event.pull_request.number
if: steps.check_changes.outputs.changes == 'true'
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
with:
script: |
Expand Down Expand Up @@ -123,7 +123,7 @@ runs:
exit 1

- name: Notify of commit
if: steps.commit_and_push.conclusion == 'success' && steps.commit_and_push.outputs.pushed == 'true' && github.event.pull_request.number
if: steps.commit_and_push.conclusion == 'success' && steps.commit_and_push.outputs.pushed == 'true'
uses: thollander/actions-comment-pull-request@24bffb9b452ba05a4f3f77933840a6a841d1b32b # v3.0.1
with:
message: |
Expand All @@ -147,7 +147,7 @@ runs:
path: ${{ inputs.working-directory }}/${{ steps.create_patch.outputs.patch_name }}

- name: Comment with patch instructions
if: steps.create_patch.outputs.patch_name && github.event.pull_request.number
if: steps.create_patch.outputs.patch_name
uses: thollander/actions-comment-pull-request@24bffb9b452ba05a4f3f77933840a6a841d1b32b # v3.0.1
with:
message: |
Expand Down
Loading