Combine reports from all `@phlexbot format` workflows by greenc-FNAL · Pull Request #380 · Framework-R-D/phlex

greenc-FNAL · 2026-03-03T21:55:39Z

Dedicated new workflow format-all.yaml is the sole responder to @phlexbot format instead of multiple "fix" workflows.
Specific "fix" workflows are called via workflow_call and results combined into a single comment to reduce clutter in the PR conversation history.
The handle-fix-commit reusable action will skip posting generated comments when called via workflow_call, allowing multiple messages to be consolidated into a single PR comment.

greenc-FNAL · 2026-03-03T21:59:19Z

@phlexbot format

github-actions · 2026-03-03T21:59:37Z

No automatic header-guards fixes were necessary.

github-actions · 2026-03-03T21:59:38Z

No automatic markdownlint fixes were necessary.

github-actions · 2026-03-03T21:59:42Z

No automatic jsonnetfmt fixes were necessary.

github-actions · 2026-03-03T21:59:45Z

No automatic cmake-format fixes were necessary.

github-actions · 2026-03-03T21:59:50Z

No automatic clang-format fixes were necessary.

greenc-FNAL · 2026-03-03T22:42:57Z

@phlexbot format

github-actions · 2026-03-03T22:43:15Z

No automatic header-guards fixes were necessary.

github-actions · 2026-03-03T22:43:19Z

No automatic jsonnetfmt fixes were necessary.

github-actions · 2026-03-03T22:43:20Z

No automatic cmake-format fixes were necessary.

github-actions · 2026-03-03T22:43:25Z

Automatic markdownlint fixes pushed (commit 2387e51).
⚠️ Note: Some issues may require manual review and fixing.

github-actions · 2026-03-03T22:43:25Z

No automatic clang-format fixes were necessary.

greenc-FNAL · 2026-03-03T23:01:17Z

@phlexbot format

github-actions · 2026-03-03T23:01:36Z

No automatic header-guards fixes were necessary.

github-actions · 2026-03-03T23:01:37Z

No automatic cmake-format fixes were necessary.

github-actions · 2026-03-03T23:01:39Z

No automatic jsonnetfmt fixes were necessary.

github-actions · 2026-03-03T23:01:42Z

No automatic markdownlint fixes were necessary.

github-actions · 2026-03-03T23:01:43Z

No automatic clang-format fixes were necessary.

greenc-FNAL · 2026-03-03T23:08:18Z

@phlexbot format

github-actions · 2026-03-03T23:08:34Z

No automatic header-guards fixes were necessary.

github-actions · 2026-03-03T23:08:41Z

No automatic jsonnetfmt fixes were necessary.

github-actions · 2026-03-03T23:08:43Z

No automatic clang-format fixes were necessary.

github-actions · 2026-03-03T23:08:43Z

No automatic cmake-format fixes were necessary.

github-actions · 2026-03-03T23:08:46Z

No automatic markdownlint fixes were necessary.

greenc-FNAL · 2026-03-03T23:12:06Z

@phlexbot format

github-actions · 2026-03-03T23:12:25Z

No automatic header-guards fixes were necessary.

- Dedicated new workflow `format-all.yaml` is the sole responder to `@phlexbot format` instead of multiple "fix" workflows. - Specific "fix" workflows are called via `workflow_call` and results combined into a single comment to reduce clutter in the PR conversation history. - The `handle-fix-commit` reusable action will skip posting generated comments when called via `workflow_call`, allowing multiple messages to be consolidated into a single PR comment. - Indicate workflow completion on invocation comment

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…uards run script, failure reporting Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>

- Per #383 (comment)

…docs - Replace `inputs.skip-comment` with `github.event_name == 'workflow_call' && inputs.skip-comment || 'false'` in all 7 fix workflows so that issue_comment triggers don't access the unavailable inputs context - Remove redundant `&& inputs.skip-comment != 'true'` from reaction step conditions that already gate on `github.event_name == 'issue_comment'` - Update format-all.yaml patch message to include artifact name and apply instructions - Update REUSABLE_WORKFLOWS.md: change skip-comment examples from boolean true to string "true", and type descriptions from boolean to string Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ssage Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>

- Per #385 (review)

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 7 comments.

Comments suppressed due to low confidence (1)

.github/actions/handle-fix-commit/action.yaml:66

When this composite action runs under workflow_call, the event payload typically won't include a PR number, so actions-comment-pull-request can fail unless the caller remembered to set skip-comment: 'true'. Consider making comment steps also conditional on a PR context being present (or on github.event_name != 'workflow_call'), or add an explicit PR number input that can be passed through to the comment action.

    - name: No changes to apply
      if: steps.check_changes.outputs.changes == 'false' && inputs.skip-comment != 'true'
      uses: thollander/actions-comment-pull-request@24bffb9b452ba05a4f3f77933840a6a841d1b32b # v3.0.1
      with:
        message: "No automatic ${{ inputs.tool }} fixes were necessary."

.github/workflows/clang-format-fix.yaml

.github/workflows/cmake-format-fix.yaml

.github/workflows/yaml-fix.yaml

.github/workflows/python-fix.yaml

.github/workflows/markdown-fix.yaml

.github/workflows/jsonnet-format-fix.yaml

.github/workflows/header-guards-fix.yaml

Wrap listForIssueComment call in try/catch so a transient API error does not fail the workflow. Narrow the bot-match predicate from the broad r.user.type === 'Bot' to r.user && r.user.login === 'github-actions[bot]' so only the reaction posted by phlexbot's pre-check step is removed. Use destructured { data: reactions } assignment for consistency with format-all.yaml.

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 9 comments.

.github/workflows/format-all.yaml

.github/workflows/cmake-format-fix.yaml

.github/workflows/header-guards-fix.yaml

.github/workflows/jsonnet-format-fix.yaml

.github/workflows/python-fix.yaml

.github/workflows/yaml-fix.yaml

.github/workflows/clang-format-fix.yaml

.github/workflows/markdown-fix.yaml

.github/REUSABLE_WORKFLOWS.md

format-all.yaml reads changes/pushed/commit_sha_short/patch_name from needs.<job>.outputs.* for each called fix workflow. GitHub Actions only surfaces these to the caller when they are explicitly re-exported under on.workflow_call.outputs; job-level outputs alone are not visible to calling workflows. Add on.workflow_call.outputs sections to all seven fix workflows, mapping to the corresponding apply-job outputs.

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

.github/actions/handle-fix-commit/action.yaml

.github/workflows/format-all.yaml

.github/REUSABLE_WORKFLOWS.md

The Get PR maintainer_can_modify property step uses context.issue.number, which is only populated when the root trigger is an issue_comment event. When a fix workflow is triggered via workflow_dispatch, context.issue.number is undefined, causing the pulls.get API call to fail whenever formatting changes are found. Note: workflow_call from format-all.yaml (triggered by issue_comment) is not affected — GitHub propagates the event payload to called workflows so context.issue.number is populated there. The bug is specific to the workflow_dispatch path. Default to 'false' for maintainer_can_modify when no PR context is available. The commit path's first condition (same-repo check) still allows pushes to proceed correctly for workflow_dispatch runs.

knoepfel · 2026-03-04T18:56:22Z

@greenc-FNAL, this PR increases the number of lines of code by ~900. What is the principal benefit of this PR?

knoepfel · 2026-03-04T19:38:18Z

@greenc-FNAL, this PR increases the number of lines of code by ~900. What is the principal benefit of this PR?

Response from Chris offline:

The principal benefit is that it allows the application of @phlexbot format to be orchestrated such that all the results are collected and combined as a single, comprehensive comment instead of (now) seven. This will substantially reduce the conversational clutter one gets on a PR when @phlexbot format is invoked multiple times, occasionally leading significant user-produced comments to be folded out of visibility before they are seen or addressed.

greenc-FNAL changed the title ~~maintenance/phlexbot format rollup~~ Combine reports from all @phlexbot format workflows Mar 3, 2026

greenc-FNAL changed the title ~~Combine reports from all @phlexbot format workflows~~ Combine reports from all @phlexbot format workflows Mar 3, 2026

greenc-FNAL changed the title ~~Combine reports from all @phlexbot format workflows~~ Combine reports from all @phlexbot format workflows Mar 3, 2026

greenc-FNAL force-pushed the maintenance/phlexbot-format-rollup branch from 9beb8c9 to 6beb6a4 Compare March 3, 2026 22:42

greenc-FNAL and others added 11 commits March 4, 2026 11:43

Update workflow documentation

8c86b2a

Prettier fixes

cab839f

Apply suggestions from code review

379a878

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Apply review feedback: string skip-comment, fix comparisons, header-g…

f3030ab

…uards run script, failure reporting Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>

Run results collection step with Bash

3a0ec42

- Per #383 (comment)

Apply suggestions from code review

64ca7ad

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Fix ref descriptions, docs examples, eyes reaction, patch artifact me…

c4fd94a

…ssage Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>

Address remaining Copilot review comments

f7b579e

- Per #385 (review)

Address latest review

ad80dea

- Per #385 (review)

greenc-FNAL force-pushed the maintenance/phlexbot-format-rollup branch from 915029e to ad80dea Compare March 4, 2026 17:43

greenc-FNAL requested a review from Copilot March 4, 2026 17:45

Copilot started reviewing on behalf of greenc-FNAL March 4, 2026 17:46 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

greenc-FNAL requested a review from Copilot March 4, 2026 18:01

Copilot started reviewing on behalf of greenc-FNAL March 4, 2026 18:01 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

greenc-FNAL requested a review from Copilot March 4, 2026 18:21

Copilot started reviewing on behalf of greenc-FNAL March 4, 2026 18:22 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

.github/actions/handle-fix-commit/action.yaml Show resolved Hide resolved

.github/workflows/format-all.yaml Show resolved Hide resolved

.github/REUSABLE_WORKFLOWS.md Show resolved Hide resolved

greenc-FNAL requested a review from knoepfel March 4, 2026 18:47

knoepfel approved these changes Mar 4, 2026

View reviewed changes

greenc-FNAL merged commit 103c08c into main Mar 4, 2026
59 checks passed

greenc-FNAL deleted the maintenance/phlexbot-format-rollup branch March 10, 2026 16:19

Conversation

greenc-FNAL commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greenc-FNAL commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

greenc-FNAL commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

greenc-FNAL commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

greenc-FNAL commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

greenc-FNAL commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greenc-FNAL commented Mar 3, 2026 •

edited

Loading