Skip to content

Fix format-all sub-workflows silently skipped when called via workflow_call #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix format-all sub-workflows silently skipped when called via workflow_call #387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82bc825
Initial plan
Copilot Mar 4, 2026
11c20b1
Fix format-all sub-workflows being skipped when called via workflow_call
Copilot Mar 4, 2026
3eec214
Suppress duplicate eyes reaction when Get PR Info runs under workflow…
Copilot Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions .github/workflows/clang-format-fix.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,14 @@ permissions:

env:
local_checkout_path:
${{ (github.event_name == 'workflow_call' && inputs.checkout-path) || format('{0}-src',
github.event.repository.name) }}
${{ inputs.checkout-path || format('{0}-src', github.event.repository.name) }}

jobs:
pre-check:
runs-on: ubuntu-latest
name: Parse command
if: >
github.event_name == 'workflow_dispatch' || github.event_name == 'workflow_call' || (
github.event_name == 'workflow_dispatch' || inputs.ref != '' || (
github.event_name == 'issue_comment' &&
github.event.issue.pull_request &&
contains(fromJSON('["OWNER", "COLLABORATOR", "MEMBER"]'), github.event.comment.author_association) &&
Expand All @@ -71,15 +70,15 @@ jobs:
# This covers repo owners, invited collaborators, and all org members.
outputs:
ref:
${{ (github.event_name == 'workflow_call' && inputs.ref) || (github.event_name == 'workflow_dispatch' &&
${{ inputs.ref || (github.event_name == 'workflow_dispatch' &&
(github.event.inputs.ref || github.ref_name)) || steps.get_pr.outputs.ref }}
repo:
${{ (github.event_name == 'workflow_call' && inputs.repo) || (github.event_name == 'workflow_dispatch' &&
${{ inputs.repo || (github.event_name == 'workflow_dispatch' &&
github.repository) || steps.get_pr.outputs.repo }}

steps:
- name: Get PR Info
if: github.event_name == 'issue_comment'
if: github.event_name == 'issue_comment' && inputs.ref == ''
id: get_pr
uses: Framework-R-D/phlex/.github/actions/get-pr-info@main

Expand Down Expand Up @@ -118,10 +117,10 @@ jobs:
token: ${{ secrets.WORKFLOW_PAT }}
pr-info-ref: ${{ needs.pre-check.outputs.ref }}
pr-info-repo: ${{ needs.pre-check.outputs.repo }}
skip-comment: ${{ github.event_name == 'workflow_call' && inputs.skip-comment || 'false' }}
skip-comment: ${{ inputs.skip-comment || 'false' }}

- name: Remove eyes reaction
if: github.event_name == 'issue_comment'
if: github.event_name == 'issue_comment' && inputs.skip-comment != 'true'
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
with:
script: |
Expand All @@ -147,7 +146,7 @@ jobs:
}

- name: Add completion reaction
if: github.event_name == 'issue_comment'
if: github.event_name == 'issue_comment' && inputs.skip-comment != 'true'
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
with:
script: |
Expand Down
17 changes: 8 additions & 9 deletions .github/workflows/cmake-format-fix.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,14 @@ permissions:

env:
local_checkout_path:
${{ (github.event_name == 'workflow_call' && inputs.checkout-path) || format('{0}-src',
github.event.repository.name) }}
${{ inputs.checkout-path || format('{0}-src', github.event.repository.name) }}

jobs:
pre-check:
runs-on: ubuntu-latest
name: Parse command
if: >
github.event_name == 'workflow_dispatch' || github.event_name == 'workflow_call' || (
github.event_name == 'workflow_dispatch' || inputs.ref != '' || (
github.event_name == 'issue_comment' &&
github.event.issue.pull_request &&
contains(fromJSON('["OWNER", "COLLABORATOR", "MEMBER"]'), github.event.comment.author_association) &&
Expand All @@ -71,15 +70,15 @@ jobs:
# This covers repo owners, invited collaborators, and all org members.
outputs:
ref:
${{ (github.event_name == 'workflow_call' && inputs.ref) || (github.event_name == 'workflow_dispatch' &&
${{ inputs.ref || (github.event_name == 'workflow_dispatch' &&
(github.event.inputs.ref || github.ref_name)) || steps.get_pr.outputs.ref }}
repo:
${{ (github.event_name == 'workflow_call' && inputs.repo) || (github.event_name == 'workflow_dispatch' &&
${{ inputs.repo || (github.event_name == 'workflow_dispatch' &&
github.repository) || steps.get_pr.outputs.repo }}

steps:
- name: Get PR Info
if: github.event_name == 'issue_comment'
if: github.event_name == 'issue_comment' && inputs.ref == ''
id: get_pr
uses: Framework-R-D/phlex/.github/actions/get-pr-info@main

Expand Down Expand Up @@ -125,10 +124,10 @@ jobs:
token: ${{ secrets.WORKFLOW_PAT }}
pr-info-ref: ${{ needs.pre-check.outputs.ref }}
pr-info-repo: ${{ needs.pre-check.outputs.repo }}
skip-comment: ${{ github.event_name == 'workflow_call' && inputs.skip-comment || 'false' }}
skip-comment: ${{ inputs.skip-comment || 'false' }}

- name: Remove eyes reaction
if: github.event_name == 'issue_comment'
if: github.event_name == 'issue_comment' && inputs.skip-comment != 'true'
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
with:
script: |
Expand All @@ -154,7 +153,7 @@ jobs:
}

- name: Add completion reaction
if: github.event_name == 'issue_comment'
if: github.event_name == 'issue_comment' && inputs.skip-comment != 'true'
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
with:
script: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/format-all.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ jobs:

check_job() {
local name="$1" result="$2" changes="$3" pushed="$4" patch_name="$5" sha_short="$6"
if [ "$result" == "failure" ] || [ "$result" == "cancelled" ]; then
if [ "$result" == "failure" ] || [ "$result" == "cancelled" ] || [ "$result" == "skipped" ]; then
messages+=("❌ $name workflow $result")
has_failures=true
elif [ "$changes" == "true" ]; then
Expand Down
17 changes: 8 additions & 9 deletions .github/workflows/header-guards-fix.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,14 @@ permissions:

env:
local_checkout_path:
${{ (github.event_name == 'workflow_call' && inputs.checkout-path) || format('{0}-src',
github.event.repository.name) }}
${{ inputs.checkout-path || format('{0}-src', github.event.repository.name) }}

jobs:
pre-check:
runs-on: ubuntu-latest
name: Parse command
if: >
github.event_name == 'workflow_dispatch' || github.event_name == 'workflow_call' || (
github.event_name == 'workflow_dispatch' || inputs.ref != '' || (
github.event_name == 'issue_comment' &&
github.event.issue.pull_request &&
contains(fromJSON('["OWNER", "COLLABORATOR", "MEMBER"]'), github.event.comment.author_association) &&
Expand All @@ -71,15 +70,15 @@ jobs:
# This covers repo owners, invited collaborators, and all org members.
outputs:
ref:
${{ (github.event_name == 'workflow_call' && inputs.ref) || (github.event_name == 'workflow_dispatch' &&
${{ inputs.ref || (github.event_name == 'workflow_dispatch' &&
(github.event.inputs.ref || github.ref_name)) || steps.get_pr.outputs.ref }}
repo:
${{ (github.event_name == 'workflow_call' && inputs.repo) || (github.event_name == 'workflow_dispatch' &&
${{ inputs.repo || (github.event_name == 'workflow_dispatch' &&
github.repository) || steps.get_pr.outputs.repo }}

steps:
- name: Get PR Info
if: github.event_name == 'issue_comment'
if: github.event_name == 'issue_comment' && inputs.ref == ''
id: get_pr
uses: Framework-R-D/phlex/.github/actions/get-pr-info@main

Expand Down Expand Up @@ -123,10 +122,10 @@ jobs:
token: ${{ secrets.WORKFLOW_PAT }}
pr-info-ref: ${{ needs.pre-check.outputs.ref }}
pr-info-repo: ${{ needs.pre-check.outputs.repo }}
skip-comment: ${{ github.event_name == 'workflow_call' && inputs.skip-comment || 'false' }}
skip-comment: ${{ inputs.skip-comment || 'false' }}

- name: Remove eyes reaction
if: github.event_name == 'issue_comment'
if: github.event_name == 'issue_comment' && inputs.skip-comment != 'true'
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
with:
script: |
Expand All @@ -152,7 +151,7 @@ jobs:
}

- name: Add completion reaction
if: github.event_name == 'issue_comment'
if: github.event_name == 'issue_comment' && inputs.skip-comment != 'true'
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
with:
script: |
Expand Down
17 changes: 8 additions & 9 deletions .github/workflows/jsonnet-format-fix.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,14 @@ permissions:

env:
local_checkout_path:
${{ (github.event_name == 'workflow_call' && inputs.checkout-path) || format('{0}-src',
github.event.repository.name) }}
${{ inputs.checkout-path || format('{0}-src', github.event.repository.name) }}

jobs:
pre-check:
runs-on: ubuntu-latest
name: Parse command
if: >
github.event_name == 'workflow_dispatch' || github.event_name == 'workflow_call' || (
github.event_name == 'workflow_dispatch' || inputs.ref != '' || (
github.event_name == 'issue_comment' &&
github.event.issue.pull_request &&
contains(fromJSON('["OWNER", "COLLABORATOR", "MEMBER"]'), github.event.comment.author_association) &&
Expand All @@ -71,15 +70,15 @@ jobs:
# This covers repo owners, invited collaborators, and all org members.
outputs:
ref:
${{ (github.event_name == 'workflow_call' && inputs.ref) || (github.event_name == 'workflow_dispatch' &&
${{ inputs.ref || (github.event_name == 'workflow_dispatch' &&
(github.event.inputs.ref || github.ref_name)) || steps.get_pr.outputs.ref }}
repo:
${{ (github.event_name == 'workflow_call' && inputs.repo) || (github.event_name == 'workflow_dispatch' &&
${{ inputs.repo || (github.event_name == 'workflow_dispatch' &&
github.repository) || steps.get_pr.outputs.repo }}

steps:
- name: Get PR Info
if: github.event_name == 'issue_comment'
if: github.event_name == 'issue_comment' && inputs.ref == ''
id: get_pr
uses: Framework-R-D/phlex/.github/actions/get-pr-info@main

Expand Down Expand Up @@ -124,10 +123,10 @@ jobs:
token: ${{ secrets.WORKFLOW_PAT }}
pr-info-ref: ${{ needs.pre-check.outputs.ref }}
pr-info-repo: ${{ needs.pre-check.outputs.repo }}
skip-comment: ${{ github.event_name == 'workflow_call' && inputs.skip-comment || 'false' }}
skip-comment: ${{ inputs.skip-comment || 'false' }}

- name: Remove eyes reaction
if: github.event_name == 'issue_comment'
if: github.event_name == 'issue_comment' && inputs.skip-comment != 'true'
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
with:
script: |
Expand All @@ -153,7 +152,7 @@ jobs:
}

- name: Add completion reaction
if: github.event_name == 'issue_comment'
if: github.event_name == 'issue_comment' && inputs.skip-comment != 'true'
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
with:
script: |
Expand Down
17 changes: 8 additions & 9 deletions .github/workflows/markdown-fix.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,14 @@ permissions:

env:
local_checkout_path:
${{ (github.event_name == 'workflow_call' && inputs.checkout-path) || format('{0}-src',
github.event.repository.name) }}
${{ inputs.checkout-path || format('{0}-src', github.event.repository.name) }}

jobs:
pre-check:
runs-on: ubuntu-latest
name: Parse command
if: >
github.event_name == 'workflow_dispatch' || github.event_name == 'workflow_call' || (
github.event_name == 'workflow_dispatch' || inputs.ref != '' || (
github.event_name == 'issue_comment' &&
github.event.issue.pull_request &&
contains(fromJSON('["OWNER", "COLLABORATOR", "MEMBER"]'), github.event.comment.author_association) &&
Expand All @@ -71,15 +70,15 @@ jobs:
# This covers repo owners, invited collaborators, and all org members.
outputs:
ref:
${{ (github.event_name == 'workflow_call' && inputs.ref) || (github.event_name == 'workflow_dispatch' &&
${{ inputs.ref || (github.event_name == 'workflow_dispatch' &&
(github.event.inputs.ref || github.ref_name)) || steps.get_pr.outputs.ref }}
repo:
${{ (github.event_name == 'workflow_call' && inputs.repo) || (github.event_name == 'workflow_dispatch' &&
${{ inputs.repo || (github.event_name == 'workflow_dispatch' &&
github.repository) || steps.get_pr.outputs.repo }}

steps:
- name: Get PR Info
if: github.event_name == 'issue_comment'
if: github.event_name == 'issue_comment' && inputs.ref == ''
id: get_pr
uses: Framework-R-D/phlex/.github/actions/get-pr-info@main

Expand Down Expand Up @@ -126,10 +125,10 @@ jobs:
token: ${{ secrets.WORKFLOW_PAT }}
pr-info-ref: ${{ needs.pre-check.outputs.ref }}
pr-info-repo: ${{ needs.pre-check.outputs.repo }}
skip-comment: ${{ github.event_name == 'workflow_call' && inputs.skip-comment || 'false' }}
skip-comment: ${{ inputs.skip-comment || 'false' }}

- name: Remove eyes reaction
if: github.event_name == 'issue_comment'
if: github.event_name == 'issue_comment' && inputs.skip-comment != 'true'
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
with:
script: |
Expand All @@ -155,7 +154,7 @@ jobs:
}

- name: Add completion reaction
if: github.event_name == 'issue_comment'
if: github.event_name == 'issue_comment' && inputs.skip-comment != 'true'
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
with:
script: |
Expand Down
17 changes: 8 additions & 9 deletions .github/workflows/python-fix.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,14 @@ permissions:

env:
local_checkout_path:
${{ (github.event_name == 'workflow_call' && inputs.checkout-path) || format('{0}-src',
github.event.repository.name) }}
${{ inputs.checkout-path || format('{0}-src', github.event.repository.name) }}

jobs:
pre-check:
runs-on: ubuntu-latest
name: Parse command
if: >
github.event_name == 'workflow_dispatch' || github.event_name == 'workflow_call' || (
github.event_name == 'workflow_dispatch' || inputs.ref != '' || (
github.event_name == 'issue_comment' &&
github.event.issue.pull_request &&
contains(fromJSON('["OWNER", "COLLABORATOR", "MEMBER"]'), github.event.comment.author_association) &&
Expand All @@ -71,14 +70,14 @@ jobs:
# This covers repo owners, invited collaborators, and all org members.
outputs:
ref:
${{ (github.event_name == 'workflow_call' && inputs.ref) || (github.event_name == 'workflow_dispatch' &&
${{ inputs.ref || (github.event_name == 'workflow_dispatch' &&
(github.event.inputs.ref || github.ref_name)) || steps.get_pr.outputs.ref }}
repo:
${{ (github.event_name == 'workflow_call' && inputs.repo) || (github.event_name == 'workflow_dispatch' &&
${{ inputs.repo || (github.event_name == 'workflow_dispatch' &&
github.repository) || steps.get_pr.outputs.repo }}
steps:
- name: Get PR Info
if: github.event_name == 'issue_comment'
if: github.event_name == 'issue_comment' && inputs.ref == ''
id: get_pr
uses: Framework-R-D/phlex/.github/actions/get-pr-info@main

Expand Down Expand Up @@ -129,10 +128,10 @@ jobs:
token: ${{ secrets.WORKFLOW_PAT }}
pr-info-ref: ${{ needs.pre-check.outputs.ref }}
pr-info-repo: ${{ needs.pre-check.outputs.repo }}
skip-comment: ${{ github.event_name == 'workflow_call' && inputs.skip-comment || 'false' }}
skip-comment: ${{ inputs.skip-comment || 'false' }}

- name: Remove eyes reaction
if: github.event_name == 'issue_comment'
if: github.event_name == 'issue_comment' && inputs.skip-comment != 'true'
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
with:
script: |
Expand All @@ -158,7 +157,7 @@ jobs:
}

- name: Add completion reaction
if: github.event_name == 'issue_comment'
if: github.event_name == 'issue_comment' && inputs.skip-comment != 'true'
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
with:
script: |
Expand Down
Loading
Loading