Skip to content

Install missing multilayer_join_node.hpp header#400

Merged
knoepfel merged 1 commit intoFramework-R-D:mainfrom
olantwin:multilayer_join_node_header
Mar 9, 2026
Merged

Install missing multilayer_join_node.hpp header#400
knoepfel merged 1 commit intoFramework-R-D:mainfrom
olantwin:multilayer_join_node_header

Conversation

@olantwin
Copy link
Contributor

@olantwin olantwin commented Mar 8, 2026

This header isn't installed, but pulled in by several of the installed headers.

@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##             main     #400   +/-   ##
=======================================
  Coverage   83.71%   83.71%           
=======================================
  Files         126      126           
  Lines        3291     3291           
  Branches      583      583           
=======================================
  Hits         2755     2755           
  Misses        325      325           
  Partials      211      211           
Flag Coverage Δ
unittests 83.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba9cba9...3666a60. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@knoepfel knoepfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @olantwin, for catching this error! The multilayer_join_node is not yet in released code, so this will not affect anyone testing the Phlex v0.1.0 prototype. This is a necessary change, however, for v0.2.0 to be released later this month.

@knoepfel knoepfel merged commit c203d82 into Framework-R-D:main Mar 9, 2026
59 checks passed
@olantwin olantwin deleted the multilayer_join_node_header branch March 9, 2026 14:12
@olantwin
Copy link
Contributor Author

olantwin commented Mar 9, 2026

No problem! I ran into some limitations with v0.1.0 which were fixed in master, so moved my prototyping to the master branch for the time being. Looking forward to v0.2.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants