Skip to content

Apply repository-wide changes from pre-commit #422

Open
knoepfel wants to merge 3 commits intoFramework-R-D:mainfrom
knoepfel:pre-commit-changes
Open

Apply repository-wide changes from pre-commit #422
knoepfel wants to merge 3 commits intoFramework-R-D:mainfrom
knoepfel:pre-commit-changes

Conversation

@knoepfel
Copy link
Member

@knoepfel knoepfel commented Mar 13, 2026

This PR also adds the markdownlint-cli2 hook, consistent with what's in our GitHub actions.

@knoepfel
Copy link
Member Author

@phlexbot markdown-fix

@github-actions
Copy link
Contributor

Automatic markdownlint fixes pushed (commit f7a098c).
⚠️ Note: Some issues may require manual review and fixing.

@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #422      +/-   ##
==========================================
- Coverage   84.22%   84.11%   -0.11%     
==========================================
  Files         128      127       -1     
  Lines        3322     3306      -16     
  Branches      564      562       -2     
==========================================
- Hits         2798     2781      -17     
- Misses        324      328       +4     
+ Partials      200      197       -3     
Flag Coverage Δ
unittests 84.11% <100.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
plugins/python/python/phlex/_typing.py 93.65% <100.00%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0471e2d...00f4f39. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@greenc-FNAL
Copy link
Contributor

Does this mean we have a hysteresis brewing, if there are changes that are different to the CI?

@knoepfel
Copy link
Member Author

Does this mean we have a hysteresis brewing, if there are changes that are different to the CI?

No. This means the pre-commit configuration did not include all of the checks that are in the CI.

@knoepfel knoepfel force-pushed the pre-commit-changes branch from e109721 to 6444297 Compare March 13, 2026 18:51
@greenc-FNAL
Copy link
Contributor

Review the full CodeQL report for details.

@greenc-FNAL
Copy link
Contributor

@knoepfel knoepfel force-pushed the pre-commit-changes branch from 6444297 to 00f4f39 Compare March 13, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants