Skip to content

Remove check for duplicate product queries#424

Merged
knoepfel merged 1 commit intoFramework-R-D:mainfrom
beojan:remove-duplicate-product-check
Mar 13, 2026
Merged

Remove check for duplicate product queries#424
knoepfel merged 1 commit intoFramework-R-D:mainfrom
beojan:remove-duplicate-product-check

Conversation

@beojan
Copy link
Contributor

@beojan beojan commented Mar 13, 2026

At the March 2026 retreat we decided this wasn't necessary.

Fixes #278

At the March 2026 retreat we decided this wasn't necessary.
Fixes Framework-R-D#278
@beojan beojan requested a review from knoepfel March 13, 2026 21:13
@beojan beojan marked this pull request as ready for review March 13, 2026 21:13
@beojan beojan added this to the Prototype 0.2 milestone Mar 13, 2026
@greenc-FNAL
Copy link
Contributor

Review the full CodeQL report for details.

@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
- Coverage   84.22%   83.96%   -0.26%     
==========================================
  Files         128      127       -1     
  Lines        3322     3306      -16     
  Branches      564      562       -2     
==========================================
- Hits         2798     2776      -22     
- Misses        324      329       +5     
- Partials      200      201       +1     
Flag Coverage Δ
unittests 83.96% <100.00%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
phlex/core/input_arguments.hpp 50.00% <ø> (-2.00%) ⬇️
phlex/core/products_consumer.hpp 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27ac10e...f7eeb3b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knoepfel knoepfel merged commit 0dfef8e into Framework-R-D:main Mar 13, 2026
38 of 41 checks passed
@beojan beojan deleted the remove-duplicate-product-check branch March 13, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should duplicate input products be permitted?

3 participants