Skip to content

Address Kyle's review comments: working-directory and jq // empty comment#428

Closed
Copilot wants to merge 0 commit intocopilot/fix-regressions-in-checksfrom
copilot/discuss-review-comments-kyle
Closed

Address Kyle's review comments: working-directory and jq // empty comment#428
Copilot wants to merge 0 commit intocopilot/fix-regressions-in-checksfrom
copilot/discuss-review-comments-kyle

Conversation

Copy link
Contributor

Copilot AI commented Mar 16, 2026

Two unresolved review comments from Kyle on PR #427, incorporating all underlying changes from that branch.

Changes

  • clang-tidy-check.yaml: Replace explicit cd "$GITHUB_WORKSPACE/${BUILD_PATH}" with the working-directory: step option, consistent with the pattern in python-check.yaml. Removes the now-redundant BUILD_PATH env var.

    # Before
    env:
      BUILD_PATH: ${{ needs.setup.outputs.build_path }}
    run: |
      cd "$GITHUB_WORKSPACE/${BUILD_PATH}"
      ...
    
    # After
    working-directory: ${{ needs.setup.outputs.build_path }}
    run: |
      ...
  • dependabot-auto-merge.yaml: Add a comment on the "Get PR details" step explaining why // empty is used in jq expressions — it produces an empty string rather than the literal "null" when a key is absent or null, so the downstream validation checks work correctly.


📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

Copilot AI changed the title [WIP] Review comments response to Kyle on PR 427 Address Kyle's review comments: working-directory and jq // empty comment Mar 16, 2026
Copilot AI requested a review from greenc-FNAL March 16, 2026 17:02
@greenc-FNAL greenc-FNAL changed the base branch from main to copilot/fix-regressions-in-checks March 16, 2026 17:24
@greenc-FNAL greenc-FNAL force-pushed the copilot/discuss-review-comments-kyle branch from 451512c to 8d3b2ff Compare March 16, 2026 17:25
@greenc-FNAL greenc-FNAL deleted the copilot/discuss-review-comments-kyle branch March 16, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants