Skip to content

Account for potential aliases like c_double vs. c_longdouble#433

Merged
knoepfel merged 1 commit intoFramework-R-D:mainfrom
knoepfel:handle-python-aliases
Mar 17, 2026
Merged

Account for potential aliases like c_double vs. c_longdouble#433
knoepfel merged 1 commit intoFramework-R-D:mainfrom
knoepfel:handle-python-aliases

Conversation

@knoepfel
Copy link
Member

On macOS, ctypes.c_longdouble is an alias for ctypes.c_double. This PR ensures that aliases are not added to a type map.

@knoepfel knoepfel requested a review from wlav March 17, 2026 19:44
@greenc-FNAL
Copy link
Contributor

Review the full CodeQL report for details.

@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
- Coverage   84.30%   84.28%   -0.02%     
==========================================
  Files         127      127              
  Lines        3314     3329      +15     
  Branches      564      564              
==========================================
+ Hits         2794     2806      +12     
  Misses        326      326              
- Partials      194      197       +3     
Flag Coverage Δ
unittests 84.28% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
plugins/python/python/phlex/_typing.py 94.02% <100.00%> (+0.37%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73a062b...a7e9d8e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knoepfel knoepfel merged commit 6d7eb1a into Framework-R-D:main Mar 17, 2026
38 checks passed
@knoepfel knoepfel deleted the handle-python-aliases branch March 17, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants