Conversation
|
Review the full CodeQL report for details. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #443 +/- ##
==========================================
+ Coverage 85.20% 86.56% +1.36%
==========================================
Files 142 144 +2
Lines 3541 4951 +1410
Branches 610 616 +6
==========================================
+ Hits 3017 4286 +1269
- Misses 314 458 +144
+ Partials 210 207 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 105 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Can you make the hierarchy publicly accessible? We would need it at graph construction time to figure out the destination layer for transforms. |
Yes, I expect we'll need to make the hierarchy publicly accessible (i.e., provide some member function of |
9a87466 to
e8989d2
Compare
marcpaterno
left a comment
There was a problem hiding this comment.
Saba and Marc have reviewed and have only one suggestion: rename data_cell to data_cell_cursor (because this is not the "data cell" described in the design doc).
Switch registration code for drivers
Include fixed_hierarchy unit test
Requested change implemented with 7b9706a.
This PR includes the changes discussed in #438. Specifically, it allows a registration like:
Behaviors:
jobdata-cell cursor is always yielded by the framework first and then passed to the user's driver function (e.g.,cells_to_process)phlex::fixed_hierarchyobject may be yielded to the framework (validation happens wheneveryield_child(...)is invoked)Resolves #438.