Default product-suffix specification#448
Merged
knoepfel merged 6 commits intoFramework-R-D:mainfrom Mar 30, 2026
Merged
Conversation
Contributor
|
Review the full CodeQL report for details. |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #448 +/- ##
==========================================
+ Coverage 85.20% 85.29% +0.08%
==========================================
Files 142 142
Lines 3541 3542 +1
Branches 610 609 -1
==========================================
+ Hits 3017 3021 +4
+ Misses 314 313 -1
+ Partials 210 208 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
knoepfel
force-pushed
the
default-suffix-specification
branch
from
900ece7 to
b4f55d5
Compare
beojan
reviewed
Mar 25, 2026
knoepfel
force-pushed
the
default-suffix-specification
branch
4 times, most recently
from
928bf3e to
2a44916
Compare
knoepfel
force-pushed
the
default-suffix-specification
branch
from
2a44916 to
5e56ac1
Compare
knoepfel
force-pushed
the
default-suffix-specification
branch
from
5e56ac1 to
e57f6a8
Compare
Member
Author
|
@beojan, I've updated this PR so that the default product suffix is the empty string. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the changes of Phlex v0.2.0 wrt. v0.1.0 is that suffixes only need to be specified to disambiguate between data products of the same type created by the same algorithm. When data products of unique types are created by an algorithm, it is not necessary to specify an output-product suffix. This PR makes this possible.
Resolves #446