Avoid fixed-size long integral types for macOS#449
Conversation
|
Review the full CodeQL report for details. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #449 +/- ##
=======================================
Coverage 84.90% 84.90%
=======================================
Files 127 127
Lines 3339 3339
Branches 575 575
=======================================
Hits 2835 2835
Misses 308 308
Partials 196 196
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
This seems like it might be too restrictive actually, there might be other platform / libc combinations where In fact, if for some crazy reason someone's using a 32-bit platform, |
|
Thinking further, the generalization would be something like and then we might as well just have the versions without fixed-width types. |
Unconditionally requiring I agree there are other systems for which A long-term solution will be the subject of another PR. |
264b31a to
d7eca9a
Compare
wlav
left a comment
There was a problem hiding this comment.
As discussed, fine for now. I'll reconsider when dealing with the refactoring and/or pull in the converters from a different place (pybind11 or cppyy) once we go to real data products.
As mentioned in a Slack discussion:
This PR is to work around the problem until we have consistent treatment of types between C++ and Python.