Merged
Conversation
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #462 +/- ##
==========================================
+ Coverage 84.88% 85.25% +0.37%
==========================================
Files 127 142 +15
Lines 3340 3541 +201
Branches 575 610 +35
==========================================
+ Hits 2835 3019 +184
- Misses 308 314 +6
- Partials 197 208 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 50 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
knoepfel
reviewed
Mar 27, 2026
knoepfel
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python-based providers in a similar vein as transform/observe. This code will need some refactoring once converters are separated out; in particular, sources and modules currently live in modulewrap.cpp because both need access to the converters (which are not public). Note that for the same reasons as with transforms, when a Python provider returns a numpy array, the data will currently be copied.