Skip to content

Warn on missing configuration for data product#473

Merged
knoepfel merged 1 commit intoFramework-R-D:mainfrom
knoepfel:switch-to-warning
Mar 30, 2026
Merged

Warn on missing configuration for data product#473
knoepfel merged 1 commit intoFramework-R-D:mainfrom
knoepfel:switch-to-warning

Conversation

@knoepfel
Copy link
Copy Markdown
Member

FORM unconditionally throws whenever a configuration is not found for a particular data product. This PR relaxes that to a warning message for now.

@knoepfel knoepfel merged commit 7d2a19a into Framework-R-D:main Mar 30, 2026
28 of 29 checks passed
@knoepfel knoepfel deleted the switch-to-warning branch March 30, 2026 21:37
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
form/form/form_writer.cpp 0.00% 4 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

@@           Coverage Diff           @@
##             main     #473   +/-   ##
=======================================
  Coverage   85.42%   85.43%           
=======================================
  Files         144      144           
  Lines        3589     3591    +2     
  Branches      615      615           
=======================================
+ Hits         3066     3068    +2     
- Misses        313      315    +2     
+ Partials      210      208    -2     
Flag Coverage Δ
unittests 85.43% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
form/form/form_writer.cpp 72.41% <0.00%> (-5.37%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af55ffc...478ae8e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants