A more inclusive handling of Catch2's use of __COUNTER__#478
A more inclusive handling of Catch2's use of __COUNTER__#478greenc-FNAL merged 3 commits intomainfrom
__COUNTER__#478Conversation
knoepfel
left a comment
knoepfel
left a comment
There was a problem hiding this comment.
One question below, @greenc-FNAL
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s Catch2 integration to avoid relying on __COUNTER__ (a non-standard compiler extension) by propagating CATCH_CONFIG_NO_COUNTER through Catch2’s CMake target usage requirements, and removes the previous Clang-specific warning suppression.
Changes:
- Bump Catch2 from
v3.10.0tov3.13.0viaFetchContent. - Add
CATCH_CONFIG_NO_COUNTERas an INTERFACE compile definition onCatch2::Catch2. - Remove the Clang>=22-specific
-Wno-c2y-extensionsworkaround.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #478 +/- ##
==========================================
+ Coverage 85.40% 85.43% +0.02%
==========================================
Files 144 144
Lines 3591 3591
Branches 615 615
==========================================
+ Hits 3067 3068 +1
Misses 315 315
+ Partials 209 208 -1
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…ld leakage Agent-Logs-Url: https://github.com/Framework-R-D/phlex/sessions/1f4caa2e-785f-4a1c-87cc-9a0c617b5417 Co-authored-by: knoepfel <7603566+knoepfel@users.noreply.github.com>
No description provided.