Skip to content

Make generated macros consistent with UPPER_CASE convention#483

Merged
knoepfel merged 1 commit intoFramework-R-D:mainfrom
knoepfel:generated-macro-case
Apr 2, 2026
Merged

Make generated macros consistent with UPPER_CASE convention#483
knoepfel merged 1 commit intoFramework-R-D:mainfrom
knoepfel:generated-macro-case

Conversation

@knoepfel
Copy link
Copy Markdown
Member

@knoepfel knoepfel commented Apr 2, 2026

Pursuant to #322 (comment)

@knoepfel knoepfel requested review from greenc-FNAL and pcanal April 2, 2026 18:32
Copy link
Copy Markdown
Contributor

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #483      +/-   ##
==========================================
- Coverage   85.49%   85.47%   -0.03%     
==========================================
  Files         142      142              
  Lines        3586     3586              
  Branches      615      615              
==========================================
- Hits         3066     3065       -1     
  Misses        310      310              
- Partials      210      211       +1     
Flag Coverage Δ
unittests 85.47% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
phlex/configuration.hpp 100.00% <ø> (ø)
phlex/core/declared_fold.hpp 95.31% <ø> (ø)
phlex/core/declared_observer.hpp 100.00% <ø> (ø)
phlex/core/declared_output.hpp 100.00% <ø> (ø)
phlex/core/declared_predicate.hpp 94.73% <ø> (ø)
phlex/core/declared_provider.hpp 100.00% <ø> (ø)
phlex/core/declared_transform.hpp 88.57% <ø> (ø)
phlex/core/declared_unfold.hpp 96.42% <ø> (ø)
phlex/core/detail/filter_impl.hpp 100.00% <ø> (ø)
phlex/core/edge_creation_policy.hpp 100.00% <ø> (ø)
... and 22 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6713ddd...c83236b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knoepfel knoepfel merged commit b23c5a1 into Framework-R-D:main Apr 2, 2026
35 checks passed
@knoepfel knoepfel deleted the generated-macro-case branch April 2, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants