clang-tidy: fix bugprone-reserved-identifier#489
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a clang-tidy finding (bugprone-reserved-identifier) in index_router by removing use of a reserved identifier in a structured binding, while preserving the existing routing/flushing cache insertion behavior.
Changes:
- Replaced structured bindings that used
_/__with direct extraction of the iterator fromtry_emplace(...).first.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #489 +/- ##
==========================================
+ Coverage 85.44% 85.47% +0.02%
==========================================
Files 142 142
Lines 3586 3586
Branches 615 615
==========================================
+ Hits 3064 3065 +1
Misses 311 311
+ Partials 211 210 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
greenc-FNAL
force-pushed
the
maintenance/clang-tidy/bugprone-reserved-identifier
branch
from
8871ac9 to
7366343
Compare
greenc-FNAL
force-pushed
the
maintenance/clang-tidy/bugprone-reserved-identifier
branch
from
ad10555 to
a634549
Compare
knoepfel
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.