Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/dev/clang-tidy-fixes-2026-04.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
1. `bugprone-*`

- [ ] bugprone-easily-swappable-parameters (41)
- [ ] bugprone-exception-escape (3)
- [x] [bugprone-exception-escape](https://github.com/Framework-R-D/phlex/pull/491) (3)
- [ ] bugprone-implicit-widening-of-multiplication-result (11)
- [ ] bugprone-macro-parentheses (398)
- [ ] bugprone-multi-level-implicit-pointer-conversion (4)
Expand Down
2 changes: 2 additions & 0 deletions phlex/app/phlex.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ using namespace std::string_literals;
using namespace boost;
namespace bpo = boost::program_options;

// NOLINTNEXTLINE(bugprone-exception-escape) -- primary application entry point; exceptions
// from potentially-throwing calls should be handled internally, not propagated from main
int main(int argc, char* argv[])
{
std::ostringstream descstr;
Expand Down
8 changes: 7 additions & 1 deletion test/form/form_root_schema_read_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
using namespace form::test;

int main(int const argc, char const** argv)
{
try {
int const technology = getTechnology(argc, argv);
if (technology < 0)
return 1;
Expand All @@ -21,4 +21,10 @@ int main(int const argc, char const** argv)
outFile << prod << std::endl;

return 0;
} catch (std::exception const& e) {
std::cerr << "Exception caught in main: " << e.what() << '\n';
return 1;
} catch (...) {
std::cerr << "Unknown exception caught in main.\n";
return 1;
}
11 changes: 9 additions & 2 deletions test/memory-checks/many_events.cpp
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
#include "phlex/core/framework_graph.hpp"
#include "plugins/layer_generator.hpp"

using namespace phlex;
#include <iostream>

using namespace phlex;
namespace {
unsigned pass_on(unsigned number) { return number; }
}

int main()
{
try {
// spdlog::flush_on(spdlog::level::trace);

constexpr auto max_events{100'000u};
Expand All @@ -24,4 +25,10 @@ int main()
.input_family(product_query{.creator = "input", .layer = "event", .suffix = "number"})
.output_product_suffixes("different");
g.execute();
} catch (std::exception const& e) {
std::cerr << "Exception caught in main: " << e.what() << '\n';
return 1;
} catch (...) {
std::cerr << "Unknown exception caught in main.\n";
return 1;
}
Loading