Skip to content

Use DISABLED test property for different_hierarchies test#492

Merged
knoepfel merged 1 commit intoFramework-R-D:mainfrom
knoepfel:disable-different-hierarchies-test
Apr 8, 2026
Merged

Use DISABLED test property for different_hierarchies test#492
knoepfel merged 1 commit intoFramework-R-D:mainfrom
knoepfel:disable-different-hierarchies-test

Conversation

@knoepfel
Copy link
Copy Markdown
Member

@knoepfel knoepfel commented Apr 8, 2026

This way, the test is explicit

⋮
      Start 14: class_registration
14/86 Test #14: class_registration ......................   Passed    0.02 sec
      Start 15: different_hierarchies
15/86 Test #15: different_hierarchies ...................***Not Run (Disabled)   0.00 sec
      Start 16: filter_impl
16/86 Test #16: filter_impl .............................   Passed    0.02 sec

⋮

100% tests passed, 0 tests failed out of 85

Label Time Summary:
DEFAULT    =  25.56 sec*proc (66 tests)
RELEASE    =  25.56 sec*proc (66 tests)

Total Test time (real) =  27.95 sec

The following tests did not run:
         15 - different_hierarchies (Disabled)

And the return code of the ctest command is still 0 if all enabled tests succeed.

@knoepfel knoepfel requested a review from greenc-FNAL April 8, 2026 13:18
Copy link
Copy Markdown
Contributor

@greenc-FNAL greenc-FNAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, didn't even know this was an option. I'm slipping …

@knoepfel
Copy link
Copy Markdown
Member Author

knoepfel commented Apr 8, 2026

Sorry, didn't even know this was an option. I'm slipping …

I didn't know about it either until I saw #488 (comment).

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
- Coverage   85.58%   85.49%   -0.09%     
==========================================
  Files         142      142              
  Lines        3586     3586              
  Branches      615      615              
==========================================
- Hits         3069     3066       -3     
  Misses        311      311              
- Partials      206      209       +3     
Flag Coverage Δ
unittests 85.49% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32f9b66...26f52db. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knoepfel knoepfel merged commit d481f4b into Framework-R-D:main Apr 8, 2026
36 checks passed
@knoepfel knoepfel deleted the disable-different-hierarchies-test branch April 8, 2026 13:36
knoepfel added a commit to knoepfel/phlex that referenced this pull request Apr 10, 2026
knoepfel added a commit to knoepfel/phlex that referenced this pull request Apr 10, 2026
sabasehrish pushed a commit that referenced this pull request Apr 10, 2026
* Use DISABLED test property for different_hierarchies test (#492)

* Silence maybe-uninitialized warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants