Skip to content

Align Code to QMK Coding Guidelines for keyboard_post_init_user()#40

Closed
heumann-a wants to merge 3 commits intoFrameworkComputer:fl16-v0.2.8-prepfrom
heumann-a:fl16-v0.2.8-prep
Closed

Align Code to QMK Coding Guidelines for keyboard_post_init_user()#40
heumann-a wants to merge 3 commits intoFrameworkComputer:fl16-v0.2.8-prepfrom
heumann-a:fl16-v0.2.8-prep

Conversation

@heumann-a
Copy link
Copy Markdown

@heumann-a heumann-a commented Jul 6, 2024

As mentioned in the QMK Guidelines all _user() functions should optimally (in best case never) used by the keyboards to be available for the keymap / user to implement own stuff.

Description

In your Macropad and Numpad keyboard you used keyboard_post_init_user() which should be used on keymap instead of keyboard level. For this i moved the functions to their respective default keymap, where they should be. The same or even more is important for layers which are specific for each keymap and should definitely only defined inside the respective keymaps (user-wide keymaps are an exception but since this is a keyboard folder, it is not applicable)

This Default keymap also serves as template to create an own keymap layout, so the code is still visible for everyone who wants to create or fork from it.

Types of Changes

  • Core
  • Bugfix
  • Enhancement/optimization

Issues Fixed or Closed by This PR

  • Compiler Error about multiple definitions of keyboard_post_init_user()
  • Move layout to keymap
  • EDIT: added funtionality to avoid triggering an event-drive layer-function permanently due syncing of numlock

Checklist

  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

PS: If approved and considered correct, pls ping me and i would like to fix the other _user() functions too, that i found. Want to avoid doing multiple PRs for nothing if you guys think otherwise and remodel it differently.

@github-actions
Copy link
Copy Markdown

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions Bot added the stale label Aug 21, 2024
@heumann-a
Copy link
Copy Markdown
Author

Not stale. still waiting for review

@github-actions github-actions Bot removed the stale label Aug 22, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 9, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions Bot added the stale label Oct 9, 2024
@benedikt-bartscher
Copy link
Copy Markdown

not stale

@github-actions github-actions Bot removed the stale label Oct 19, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 3, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions Bot added the stale label Dec 3, 2024
@heumann-a
Copy link
Copy Markdown
Author

heumann-a commented Dec 23, 2024

not stale, still waiting for review...!

@github-actions github-actions Bot removed the stale label Dec 24, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 8, 2025

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions Bot added the stale label Feb 8, 2025
@github-actions
Copy link
Copy Markdown

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions Bot closed this Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants