Python: Fix self-assigned fields and or-expression type propagation#2602
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lshala
marked this pull request as ready for review
February 24, 2026 12:31
lshala
marked this pull request as draft
February 24, 2026 14:05
maximiliankaul
approved these changes
Mar 4, 2026
maximiliankaul
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Maybe double check with someone more familiar with our assignedTypes functionality.
lshala
marked this pull request as ready for review
March 4, 2026 16:32
KuechA
approved these changes
Mar 5, 2026
KuechA
pushed a commit
that referenced
this pull request
Mar 20, 2026
…2602) * Add second test * Fix failing test and adjust binary operator handling * Add assert * Handle or and and operators via assignedTypes * Refactor default implementation of propagateAssignedTypes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two related fixes:
selfhas anUnknownType. This prevented calls on those fields from being resolved.Partially fixes #2575