Skip to content

Tagging typically depends on DFG and also on EOG #2778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KuechA wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Tagging typically depends on DFG and also on EOG #2778

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cpg-concepts/src/main/kotlin/de/fraunhofer/aisec/cpg/passes/concepts/TagOverlaysPass.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ import de.fraunhofer.aisec.cpg.TranslationContext
import de.fraunhofer.aisec.cpg.graph.Node
import de.fraunhofer.aisec.cpg.graph.OverlayNode
import de.fraunhofer.aisec.cpg.passes.ControlFlowSensitiveDFGPass
import de.fraunhofer.aisec.cpg.passes.DFGPass
import de.fraunhofer.aisec.cpg.passes.Description
import de.fraunhofer.aisec.cpg.passes.EvaluationOrderGraphPass
import de.fraunhofer.aisec.cpg.passes.PassConfiguration
import de.fraunhofer.aisec.cpg.passes.PointsToPass
import de.fraunhofer.aisec.cpg.passes.SymbolResolver
Expand All @@ -43,6 +45,8 @@ import de.fraunhofer.aisec.cpg.passes.configuration.DependsOn
@DependsOn(SymbolResolver::class)
@DependsOn(ControlFlowSensitiveDFGPass::class, true)
@DependsOn(PointsToPass::class, true)
@DependsOn(DFGPass::class, true)
@DependsOn(EvaluationOrderGraphPass::class)

@oxisto oxisto Jun 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SymbolResolver should already depend on EOG, so does CF-DFG and/or PointsToPass. Why is this even necessary?

@KuechA KuechA Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For CF-DFG and PointsToPass: These are optional, so if we do not register them, it means that only the SymbolResolver is left. I saw this pass being executed before the DFG Pass which was strange. And I prefer to have such dependencies/assumptions written down explicitly. But I agree, the EOG may not be strictly necessary here.

@Description("Tags overlay nodes to underlying nodes based on a tagging context.")
open class TagOverlaysPass(ctx: TranslationContext) : EOGConceptPass(ctx) {

Expand Down
Loading