Skip to content

Conversation

@Shuyinsama
Copy link

Also tested the changes to a Keycloak 9.0.1 and 10.0.2 instance

@Shuyinsama
Copy link
Author

I've updated the PR to make the client_secret property optional. It seems that the initial code was working for some people even though I've never got this working without client_secret.

This way we can still accommodate both ways

@Shuyinsama
Copy link
Author

@Fredx87 Do you have an idea when you will be able to review this PR? I am eagerly waiting so we can start using these changes in our project :)

@RubenGarcia
Copy link

I also request merging of this feature.

@Thanoonazad
Copy link

Hi guys I just want to ask if there is any reason why this pull requests did not be merged yet?

@qws777
@Shuyinsama
@RubenGarcia

@Shuyinsama
Copy link
Author

@Thanoonazad I have no idea. I have ultimately implemented this code into my own project. No need for a fork or whatever. This repo is not that big and you can copy paste most of the code to your project and it will work.

@metalmini
Copy link

metalmini commented May 7, 2021

@Fredx87 Is there a reason this PR lingers for so long? I mean, everything is ✅ and the reviewer already approved it.

@JordiGiros
Copy link

@Fredx87 Can you merge this, please? Great addition and a lot of people waiting for it.

@jdtully
Copy link

jdtully commented Jun 15, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants