-
Notifications
You must be signed in to change notification settings - Fork 29
Add client_secret to kcLogin command #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add client_secret to kcLogin command #15
Conversation
|
I've updated the PR to make the This way we can still accommodate both ways |
|
@Fredx87 Do you have an idea when you will be able to review this PR? I am eagerly waiting so we can start using these changes in our project :) |
|
I also request merging of this feature. |
|
Hi guys I just want to ask if there is any reason why this pull requests did not be merged yet? |
|
@Thanoonazad I have no idea. I have ultimately implemented this code into my own project. No need for a fork or whatever. This repo is not that big and you can copy paste most of the code to your project and it will work. |
|
@Fredx87 Is there a reason this PR lingers for so long? I mean, everything is ✅ and the reviewer already approved it. |
|
@Fredx87 Can you merge this, please? Great addition and a lot of people waiting for it. |
|
I have been watching for movement on this for over a year, what can
be done if the otirignal poster never responds?
?
…On Fri, May 7, 2021 at 5:41 AM Michael Schouman ***@***.***> wrote:
@Fredx87 <https://github.com/Fredx87> Is there a reason this PR lingers
for so long? I mean, everything is ✅ and the reviewer already approved it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALVKJ2V2KB6QV7DA3LE4D3LTMOYT3ANCNFSM4NYN6PGA>
.
--
Jeffrey Tully
|
Also tested the changes to a Keycloak 9.0.1 and 10.0.2 instance