consistency between IPv4 and IPv6

FreeRADIUS · Apr 6, 2024 · e975780 · e975780
1 parent 032bc1c
commit e975780
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/pam_radius_auth.c b/src/pam_radius_auth.c
@@ -1577,15 +1577,16 @@ PAM_EXTERN int pam_sm_authenticate(pam_handle_t *pamh, UNUSED int flags, int arg
 
 		attribute_t *attr_fip;
 		if ((attr_fip = find_attribute(response, PW_FRAMED_ADDRESS))) {
-			char frameip[100];
+			const char name[] = "Framed-IP-Address";
+			char frameip[sizeof(name) + INET_ADDRSTRLEN];
 			struct in_addr ip_addr;
 
 			ip_addr.s_addr = *(int*) attr_fip->data;
 
-			snprintf(frameip, sizeof(frameip), "Framed-IP-Address=%s", inet_ntoa(ip_addr));
+			snprintf(frameip, sizeof(frameip), "%s=%s", name, inet_ntoa(ip_addr));
 			retval = pam_putenv(pamh, frameip);
-			if(retval != PAM_SUCCESS) {
-				_pam_log(LOG_ERR, "unable to set PAM environment variable : Framed-IP-Address");
+			if (retval != PAM_SUCCESS) {
+				_pam_log(LOG_ERR, "unable to set PAM environment variable : %s", name);
 			}
 			else {
 				_pam_log(LOG_DEBUG, "Set PAM environment variable : %s", frameip);