Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure Sockets Transport Implementation #146

Closed
wants to merge 8 commits into from

Conversation

diogosilva0307
Copy link

@diogosilva0307 diogosilva0307 commented Sep 1, 2023

Description

  • This pull request allows to create sockets with SSL, as well as upload files to the system storage (certificates for example).
  • There were added two new options to the CellularSocketOption_t struct as well as another option to the CellularSocketOptionLevel_t struct.
  • This was tested with BG96 module.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

#74 [Feature Request] Secure Sockets Transport Implementation
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@chinglee-iot chinglee-iot self-requested a review September 2, 2023 02:51
@chinglee-iot
Copy link
Member

Thank you for the PR. I will look into it and discuss with you here.

@chinglee-iot
Copy link
Member

@diogosilva0307
Thank you for creating this PR. Besides BG96, we also look into other cellular modems like SARA-R4 and HL7802 specific AT commands to support secure socket connection. We would like to do the following changes base on this PR:

  1. Move Cellular_ConfigureSSLContext and Cellular_UploadFileToStorage to port specific layer APIs. The AT commands to configure SSL context and upload credentials is different for cellular modems. Therefore, we would like to move these APIs to a port specific header, for example cellular_bg96_api.h. User who wants to use secure socket connection feature will need to include the port specific header.
  2. Move CellularSocketSslConfig_t to port implementation. A pModemData pointer is defined in Cellular socket context for port to extend the socket context. In this way, modem port can define it's own socket specific data without altering the cellular interface.

The PR #147 is created with these changes. We would like to invite you to take a look and feedback in this PR.

@chinglee-iot
Copy link
Member

@diogosilva0307
This PR is covered #147
We would like to close this PR due to no response in both PRs.
Feel free to reopen this PRs if you have any updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants