Add CELLULAR_CONFIG_USE_CCID_COMMAND config for ICCID #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add config CELLULAR_CONFIG_USE_CCID_COMMAND to use non-standard AT command "AT+CCID" for ICCID information in Cellular_CommonGetSimCardInfo.
ActoryOu
approved these changes
Nov 20, 2023
kar-rahul-aws
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feedback from forum AT+CCID is not 3GPP standard AT command. However, it is supported by many existing port including SARA-R4 and HL7802. Add this config to consider in backward compatibility. New port can still use proprietary AT command to get ICCID information and
Cellular_CommonGetSimCardInfofor the rest inCellularSimCardInfo_t.CELLULAR_CONFIG_USE_CCID_COMMANDto use non-standard AT command "AT+CCID" for ICCID information inCellular_CommonGetSimCardInfo.Test Steps
N/A
Checklist:
I have modified and/or added unit-tests to cover the code changes in this Pull Request.Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.