Add cast in stack allocation for task creation #1340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moninom1
approved these changes
Dec 15, 2025
AhmedIsmail02
approved these changes
Dec 18, 2025
Member
AhmedIsmail02
left a comment
AhmedIsmail02
left a comment
There was a problem hiding this comment.
This typecast was previously removed here. However, since pvPortMallocStack() may be provided by the application when configSTACK_ALLOCATION_FROM_SEPARATE_HEAP is set to 1, its return type is not fixed across all configurations. Adding the explicit cast restores consistency with existing kernel code and makes the intended pointer type explicit.
Member
|
@sidharth-458 Could you please rebase your branch with the latest version of the main branch? This should fix the failing |
for negative portSTACK_GROWTH, add cast to stack allocation, just like it is in positive portSTACK_GROWTH
sidharth-458
force-pushed
the
add_cast_in_stack_allocation
branch
from
82187b5 to
e430418
Compare
|
Author
|
@AhmedIsmail02 I have rebased my branch, is it ok now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cast in stack allocation for task creation
Description
for negative portSTACK_GROWTH, add cast to stack allocation, just like it is in positive portSTACK_GROWTH
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.