Skip to content

Commit

Permalink
nightly-ci: Run tests as part of script section
Browse files Browse the repository at this point in the history
pytests inside the nightly jobs `sw-vsi-config-test`,
and `gnu-toolchain-test` should be run as part of the
`script` section of these jobs as running the tests
in the `after_script` section of these jobs won't
have an influence on the exit code of the pipeline
which might lead to false negative misleading CI results.

Signed-off-by: Ahmed Ismail <[email protected]>
  • Loading branch information
AhmedIsmail02 authored and urutva committed May 23, 2024
1 parent 8a7ac0f commit a8f20fc
Showing 1 changed file with 18 additions and 10 deletions.
28 changes: 18 additions & 10 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -328,13 +328,17 @@ integration-tests:
GIT_SUBMODULE_STRATEGY: recursive

sw-vsi-configs-test:
extends:
- .build_job
tags:
- iotmsw-amd64
extends: .base-job-rules
rules:
- if: ( $SCHEDULED_JOB_TO_RUN == "sw-vsi-configs-test" )
after_script:
# test_job's `before_script` section is referenced in the `after_script` section to set the correct value for FVP_BIN variable used in testing.
# test-applications_base job's `script` section is referenced in the `after_script` section of
before_script:
- !reference [.build_job, before_script]
- !reference [.build_job, script]
script:
# test_job's `before_script` section is referenced in the `script` section to set the correct value for FVP_BIN variable used in testing.
# test-applications_base job's `script` section is referenced in the `script` section of
# this job to do the testing part after the build stage is done where the build stage is inherited
# from `.build_job`
- !reference [.test_job, before_script]
Expand Down Expand Up @@ -393,13 +397,17 @@ sw-vsi-configs-test:
GIT_SUBMODULE_STRATEGY: recursive

gnu-toolchain-test:
extends:
- .build_job
tags:
- iotmsw-amd64
extends: .base-job-rules
rules:
- if: ( $SCHEDULED_JOB_TO_RUN == "gnu-toolchain-test" )
after_script:
# test_job's `before_script` section is referenced in the `after_script` section to set the correct value for FVP_BIN variable used in testing.
# test-applications_base job's `script` section is referenced in the `after_script` section of
before_script:
- !reference [.build_job, before_script]
- !reference [.build_job, script]
script:
# test_job's `before_script` section is referenced in the `script` section to set the correct value for FVP_BIN variable used in testing.
# test-applications_base job's `script` section is referenced in the `script` section of
# this job to do the testing part after the build stage is done where the build stage is inherited
# from `.build_job`
- !reference [.test_job, before_script]
Expand Down

0 comments on commit a8f20fc

Please sign in to comment.