cpp-check: Fix cpp-check's findings

cpp-check aims to provide unique code analysis to detect bugs, this commit fixes cpp-check findings which prevents having an undefined behaviour when executing our code. Signed-off-by: Ahmed Ismail <[email protected]>
FreeRTOS · Oct 19, 2023 · ea7b6fe · ea7b6fe
1 parent 971b814
commit ea7b6fe
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/Middleware/ARM/IoT_VSocket-lib/transport_tls_iot_socket.c b/Middleware/ARM/IoT_VSocket-lib/transport_tls_iot_socket.c
@@ -37,7 +37,7 @@ TransportStatus_t Transport_Connect( NetworkContext_t * pNetworkContext,
                                      uint32_t recvTimeoutMs )
 {
     TransportStatus_t status = TRANSPORT_STATUS_SUCCESS;
-    int32_t socketStatus = 0;
+    int32_t socketStatus;
     uint8_t ipAddr[ 4 ];
     uint32_t ipAddrLen;
     TLSHelperParams_t tlsHelperParams = { 0 };
@@ -257,14 +257,14 @@ static int Send_Cb( void * pvCallerContext,
 TransportStatus_t Transport_Disconnect( NetworkContext_t * pNetworkContext )
 {
     TransportStatus_t status = TRANSPORT_STATUS_SUCCESS;
-    int32_t socketStatus;
 
     if( pNetworkContext == NULL )
     {
         status = TRANSPORT_STATUS_INVALID_PARAMETER;
     }
     else
     {
+        int32_t socketStatus;
         do
         {
             socketStatus = iotSocketClose( pNetworkContext->socket );

diff --git a/Projects/aws-iot-example/event-helper/event_helper.c b/Projects/aws-iot-example/event-helper/event_helper.c
@@ -58,5 +58,5 @@ bool xIsMqttAgentConnected( void )
 {
     EventBits_t uxEvents = xEventGroupGetBits( xSystemEvents );
 
-    return( ( bool ) ( uxEvents & EVENT_MASK_MQTT_CONNECTED ) );
+    return( ( uxEvents & EVENT_MASK_MQTT_CONNECTED ) == 0 ? false : true );
 }
diff --git a/Projects/aws-iot-example/main.c b/Projects/aws-iot-example/main.c
@@ -64,12 +64,12 @@ extern uint32_t tfm_ns_interface_init( void );
 void vAssertCalled( const char * pcFile,
                     unsigned long ulLine )
 {
-    volatile unsigned long looping = 0;
-
-    printf( "ASSERT failed! file %s:%ld, \n", pcFile, ulLine );
+    printf( "ASSERT failed! file %s:%lu, \n", pcFile, ulLine );
 
     taskENTER_CRITICAL();
     {
+        volatile unsigned long looping = 0;
+
         /* Use the debugger to set ul to a non-zero value in order to step out
          *      of this function to determine why it was called. */
         while( looping == 0LU )

diff --git a/Projects/blinky/main.c b/Projects/blinky/main.c
@@ -18,12 +18,12 @@ extern uint32_t tfm_ns_interface_init( void );
 void vAssertCalled( const char * pcFile,
                     unsigned long ulLine )
 {
-    volatile unsigned long looping = 0;
-
-    printf( "ASSERT failed! file %s:%ld, \r\n", pcFile, ulLine );
+    printf( "ASSERT failed! file %s:%lu, \r\n", pcFile, ulLine );
 
     taskENTER_CRITICAL();
     {
+        volatile unsigned long looping = 0;
+
         /* Use the debugger to set ul to a non-zero value in order to step out
          *      of this function to determine why it was called. */
         while( looping == 0LU )